Possible extractor log bug
Firstly, thank you for the really useful software, it make dose audits a breeze!
I’ve recently set the software up and am troubleshooting an import issue but I noticed my extractor log was blank. I am a bit of a novice at this so it’s probably my setup but it looks to me like when you had implemented the Toshiba extractor error log (in settings.py) this bit:
'remapp.extractors.ct_toshiba': {
'handlers': ['extractor_file'],
'level': 'INFO',
'propagate': False,
},
seems to have replaced the bit that was setting the handler for the general extractor log. I’ve set it back and it started working.
Apologies if I’ve just completely misunderstood but thought I should let you know just in case.
Thanks again
Matt
Comments (12)
-
-
reporter I’ve been running the rdsr.py extractor to import dose report files and I was expecting this to write to the openrem_extractor.log (i’d set the logging threshold to debug) however it didn’t and the log file remained completely blank.
In settings.py, I changed line 240 from ‘remapp.extractors.ct_toshiba’ to ‘remapp.extractors.rdsr’. I then resumed importing files and the log file was successfully written to.
Thanks
Matt
-
Sorry I never followed this up Matthew - it looks like you are right. I’ll see if I can fix this up for 1.0.
-
- changed component to Import: All
- changed milestone to 1.0.0
-
Modifying the extractor log config to work with all extractors instead of just Toshiba. Refs
#764→ <<cset aeb804ae2450>>
-
Attempting to resolve changes to tests with logging. Refs
#764→ <<cset 8ba44f706fb8>>
-
Fixing tests I broke last night. Refs
#764→ <<cset 30d9044bfd82>>
-
Correcting changes log for ref
#764→ <<cset 4331035c4b94>>
-
Black, after changes for ref
#764→ <<cset 096ca70cd4a4>>
-
Updating docs for Docker. Refs
#764[skip ci] docs only→ <<cset 245ac61f39c7>>
-
- changed status to resolved
-
Removing references to the native store. Log itself removed with ref
#764. Refs#892. Also improved message for missing peer.→ <<cset bccc3eca0d40>>
- Log in to comment
HI @Matthew Dixon - can you give us some more information about
I have just had a quick look, and I think the logging is working as designed, but possible not as you (and probably other users) expect it to!
Your feedback on this would be very helpful.
Thanks, Ed.