PHEradiographicProjectionExportMissingAcquisitionProtocolName

[David Platten]

The PHE radiographic export for individual projections does not include the acquisition protocol name.

[David Platten]

Changed PHE radiographic projection export so that acquisition protocol is written to the file rather than procedure code, requested procedure and study description. Also fixed bug where downloading the export file failed because the built-in Python 2.x file() function does not exist in Python 3.x. References issue #795 and issue #796

→ <<cset d5d56f9cfc2d>>

[David Platten]

Updated changes files [skip ci]. References issue #795 and issue #796

→ <<cset 3da359ca0104>>

[David Platten]

Fixed merge conflicts. References issue #795

→ <<cset d7f0640a431f>>

[Ed McDonagh]

Fixing issue of how NoneType is dealt with in Python3; reformatting using f-strings. Refs #795

→ <<cset 6c4a83f057f4>>

[Ed McDonagh]

Alternative for @dplatten to consider. Refs #795 * Rather than replacing study level with acquisition, why not add it?

→ <<cset 53848648564e>>

[Ed McDonagh]

Removing second pipe. Refs #795

→ <<cset 1f87f351f474>>

[David Platten]

Simplified code that adds the acquisition protocol name; I agree that this is the way to go. There's some inconsistency in the use of the u character before quotes in the dx_export file. Should all empty quotes have a u in front of them? References issue #795

→ <<cset 587b53f1270f>>

[Ed McDonagh]

Regarding your modification, I think you have created an extra column? I think the correct approach is to create the string that is applicable to both, then if projection append to the string, and only then add the string to the list.

The u prefix is harmless but unnecessary in Python 3, so I am removing it as I go through. It isn’t trivial to find and replace them so I haven’t bothered.

You’ll have noticed I am also moving to the Python 3.6+ syntax for string formatting, f-strings. They are much easier to read than '{0}'.format(value) and there are other advantages too.

[David Platten]

Corrected code to avoid creating an extra column. I can confirm that the export works as expected. References issue #795

→ <<cset 6dedb068276d>>

[Ed McDonagh]

Shortening line, but not to the 100 characters suggested. Need to work out how to tune Codacy check! Refs #795

→ <<cset c35467ec32d7>>

[Ed McDonagh]

Merged in issue795PHEradiographicProjectionExportMissingAcquisitionProtocolName (pull request #341)

FIxes #795

Approved-by: Ed McDonagh

→ <<cset e93525e2f294>>