Issue #795 resolved
David Platten created an issue

The PHE radiographic export for individual projections does not include the acquisition protocol name.

Comments (11)

  1. David Platten reporter

    Changed PHE radiographic projection export so that acquisition protocol is written to the file rather than procedure code, requested procedure and study description. Also fixed bug where downloading the export file failed because the built-in Python 2.x file() function does not exist in Python 3.x. References issue #795 and issue #796

    → <<cset d5d56f9cfc2d>>

  2. David Platten reporter

    Simplified code that adds the acquisition protocol name; I agree that this is the way to go. There's some inconsistency in the use of the u character before quotes in the dx_export file. Should all empty quotes have a u in front of them? References issue #795

    → <<cset 587b53f1270f>>

  3. Ed McDonagh

    Regarding your modification, I think you have created an extra column? I think the correct approach is to create the string that is applicable to both, then if projection append to the string, and only then add the string to the list.

    The u prefix is harmless but unnecessary in Python 3, so I am removing it as I go through. It isn’t trivial to find and replace them so I haven’t bothered.

    You’ll have noticed I am also moving to the Python 3.6+ syntax for string formatting, f-strings. They are much easier to read than '{0}'.format(value) and there are other advantages too.

  4. Log in to comment