StationName exceeding 16 characters in length

Issue #799 resolved
Tim de Wit created an issue

AGFA EI seems to allow stationnames longer than 16 characters, thereby not respecting the SH value representation. This currently results in qrscu crashing with error message:

DataError: value too long for type character varying(16)

Reference: discussion in openrem forum thread https://groups.google.com/forum/#!topic/openrem/ynWJdWjmlzM
Ed’s suggested fix: increase the length of stationname field in modals.py

Comments (10)

  1. Ed McDonagh

    Do you want to make a branch of develop called issue799stationnamelength or similar and change both of the StationName values to 64?

    You can then create a Pull Request, and we can get your name back in the commit record 😉

  2. Tim de Wit reporter

    Ok, will do! I also found several other occurrences of station_name as well, in classes UniqueEquipmentNames and GeneralEquipmentModuleAttr (both 32 characters). Shouldn’t I change those as well?

  3. Ed McDonagh

    I don’t think we should change those, because that would mess up all the unique equipment name hashes in everyone’s databases!

    Whether we should therefore default to 32 for the QR station name, or go with my original proposal of 64 I don’t know. I don’t think it really matters - what sort of length station names were you finding?

  4. Tim de Wit reporter

    Agreed.. in that case it makes most sense to use 32 everywhere.
    The examples I found were around 18-20 characters so 32 would be fine. In the meanwhile I’ve confronted AGFA with them breaking dicom compliance and they will implement a fix in our hospital soon (truncate station name both on incoming and outgoing dicom connections). In that sense it won’t be necessary anymore, but I think it won’t hurt (or cost anything) to increase the length from 16 to 32.

  5. Ed McDonagh

    Can you do a migration to 32 characters - I don’t know how it deals with making the string shorter?

  6. Log in to comment