qrscu traceback / stack trace not visible in openrem_qr.log

[Tim de Wit]

qrscu tracebacks seem to be “swallowed” by celery, making debugging hard. It would perhaps be helpful if tracebacks would be added to the openrem_qr.log automatically.

[Tim de Wit]

The above seems to be possible by adding the following code to qrscu.py:

...

logger = logging.getLogger('remapp.netdicom.qrscu')  # Explicitly named so that it is still handled when using __main__

from celery import Task

class LogErrorsTask(Task):
    def on_failure(self, exc, task_id, args, kwargs, einfo):
        logger.exception('Failure on Celery task {0}'.format(task_id), exc_info=exc)
        super(LogErrorsTask, self).on_failure(exc, task_id, args, kwargs, einfo)

adding additional argument to the @shared_task decorators:

@shared_task(name='remapp.netdicom.qrscu.qrscu', base=LogErrorsTask)
@shared_task(name='remapp.netdicom.qrscu.movescu', base=LogErrorsTask)

Happy to commit these modifications if you think it’s useful… just let me know.

[Ed McDonagh]

Cool. I’ll take a look later. Thanks for all your work today!

Have you got a reference for where you got this method from?

[Tim de Wit]

Sorry forgot to mention the sources:
https://stackoverflow.com/questions/16658371/how-to-log-exceptions-occurring-in-a-django-celery-task
https://gist.github.com/darklow/c70a8d1147f05be877c3

[Ed McDonagh]

HI @Tim de Wit - this looks like a sensible thing to do. My only reservation is that I don’t recall being aware that I was missing anything in the current setup!

Can you put a PR together please?

[Tim de Wit]

Enable logging of stack traces inside qrscu Celery tasks. Refs #806.

→ <<cset 2a82347a4d60>>

[Ed McDonagh]

Celery no longer in use, and additional QR feedback now incorporated into 1.0, so marking as wontfix.