Canon (Toshiba) fluoro RDSR with mGy RP dose units

[David Platten]

A newly-installed Canon Ultimax-i creates DICOM RDSR objects which store dose at reference point values as mGy. These should be stored as Gy. As a result the dose at reference point values in OpenREM are a factor of 1000 too high. Need to implement a check for RP dose units in a similar way to what was used for DAP units in issue #704.

[David Platten]

Added method to check dose at RP units and adjust if mGy found. References issue #808

→ <<cset 59d8998e70e1>>

[David Platten]

Added tests for the new RP units check; also updated changes files. References issue #808

→ <<cset d81fea4b7ca4>>

[David Platten]

Added tblib to the tox file to invetsigate why tests are failing. References issue #808

→ <<cset 24dc91b489a7>>

[David Platten]

Moved the section that tblib is in... References issue #808

→ <<cset 74182a24f432>>

[Ed McDonagh]

Have you got the right field? Haven’t looked through properly yet, but row 21 of TID 10003 is for Mammo and should be in mGy (which is what is currently failing in pipeline)

[Ed McDonagh]

Should it be row 1 of TID 10003B instead? DCM_113738 Dose (RP) rather than DCM_111636 Entrance Exposure at RP

[David Platten]

Removed reference point dose units check in the TID 10003 section as this should be in mGy. Left the check in-place for reference point doses in TID 10003B (http://dicom.nema.org/medical/Dicom/2017e/output/chtml/part16/sect_TID_10003b.html), 10004 (http://dicom.nema.org/medical/Dicom/2017e/output/chtml/part16/sect_TID_10004.html) and 10007 (http://dicom.nema.org/medical/Dicom/2017e/output/chtml/part16/sect_TID_10007.html). References issue #808

→ <<cset c966a042feb2>>

[David Platten]

Hooray for the built-in testing.

[Ed McDonagh]

Amen to that!

While you’re in there, can you update the tags you’ve changed as per this example to use code values rather than code meanings?

At some point I’ll be changing them all (possibly making use of the new SR capabilities of pydicom, currently write only), but I’m changing as I touch things anyway.

We’ve had trouble before with manufacturers misspelling the meanings, or just changing the text. And David Clunie says one must never rely on the meanings!

[David Platten]

Added test to check that reference point dose is correctly imported from a Canon Ultimax-i where the values are stored in the RDSR in mGy. I can't run tests locally, so not sure if I have the correct event index at the moment. References issue #808

→ <<cset 4d6462985165>>

[David Platten]

Correcting values in the new tests. Added test for total dose at RP. References issue #808

→ <<cset faa3df113ce5>>

[David Platten]

Now checking against CodeValue instead of CodeMeaning for the dose at reference point data. Will avoid problems where manufacturers sometimes misspell CodeMeaning. References issue #808

→ <<cset a38e6cd7722f>>

[David Platten]

Adding extra space before in-line comment to conform with PEP 8 (https://www.python.org/dev/peps/pep-0008/). References issue #808

→ <<cset 3e75815fd681>>

[Ed McDonagh]

Changed DICOM link to current, added next 200 issue links to changes. Refs #808

→ <<cset b9271d87528f>>

[Ed McDonagh]

Merged in issue808checkUnitsOfDoseAtRP (pull request #350)

Fixes #808

Approved-by: Ed McDonagh

→ <<cset 081ea89343e8>>