Incorrect histogram data in charts
As reported on the Google Group here: https://groups.google.com/forum/#!topic/openrem/FsQLyh32hxk
In some situations the histogram data associated with a data point can be incorrect.
Setting “Case-insensitive categories” in the “Config → Chart options” appears to be a work-around for the time being.
Comments (28)
-
reporter -
I don’t have a good handle on the relative effort required, or your appetite for the task…
-
reporter I think that fixing the existing charts would be the best approach for now. I’ll try to set up a development environment with the current develop branch in Windows…
-
Hi @David Platten - do you think you might have any time soon to knock some of these chart related issue off?
Thanks, Ed
-
reporter @Ed McDonagh I’ll take a look at this next week.
-
reporter Adding some notes on the data structure for bar chart data. Incomplete at the moment. References issue
#830→ <<cset 11ec9ec9cf01>>
-
reporter Revising notes on the data structure for bar chart data. Incomplete at the moment. References issue
#830→ <<cset eb3a0ff7c44a>>
-
reporter Starting to implement Pandas DataFrame for chart data. References issue
#830→ <<cset 6727684eb597>>
-
reporter Passing the JavaScript a JSON copy of the Pandas DataFrame. Need to re-write the JavaScript to deal with this. Started, but needs further work. Wondering if I should replace HighCharts at this point as one of the alternatives may accept the new data as-is. References issue
#830→ <<cset 4cd9911e4c2f>>
-
reporter Simple Altair-based chart working for mean or median DLP per requested procedure name. No histograms at the moment, and the chart formatting isn't great. However, the chart creation and display works. References issue
#830and issue#477→ <<cset 4c5102ae9fb6>>
-
reporter Added some test code that makes the browser JavaScript calculate the mean or median values (not implemented for the combined plot of mean and median). This may cause memory or performance issues I think, due to the potentially very large object size passed to the browser. References issue
#830and issue#477→ <<cset 5cca47bd06c9>>
-
reporter Commended out the 'raw' charts - the ones where the server calculates the aggregates are faster (on my i9 laptop). References issue
#830and issue#477→ <<cset 2f3beaae2eb4>>
-
reporter Removed HighCharts-related JavaScript. Added tooltip, legend title, y-axis title. I've tried to make the chart fit the DIV, but cannot work out how to do that at the moment. References issue
#830and issue#477→ <<cset c8f2992c8e03>>
-
reporter Added stacked bar chart in place of pie chart for frequency of requested procedure names. Produces a bar per x-ray system (an improvement on the pie chart). References issue
#830and issue#477→ <<cset b362805a40c6>>
-
reporter Added Altair charts for remaining CT frequency and average charts. References issue
#830and issue#477→ <<cset ecdbd6353a7f>>
-
Adding altair to requirements. Refs
#830→ <<cset 48e2c5ff2c1a>>
-
reporter Switched average plots so that the categories are stacked vertically (one column, lots of rows). This avoids an issue where the width gets too large. References issue
#830and issue#477→ <<cset f1cf683996ad>>
-
reporter Refactored Altair chart code into separate functions per chart type. Added all CT histograms. All CT charts now using Altair. Workload chart doesn't have per-hour data at the moment. References issue
#477and#830→ <<cset 2e9307e994b9>>
-
Adding plotly to requirements. Refs
#830.→ <<cset 51b17f084b1a>>
-
reporter Resolving merge conflicts when pulling develop into this branch. Refs issue
#830→ <<cset 45d179ffc301>>
-
reporter Updading changes file [skip ci]. Refs issue
#477and issue#830→ <<cset a40097c7407d>>
-
Removing Python 2.7 migration imports, removing requirement to import remapp, moving numpy out of standard imports. Refs
#830→ <<cset 12a038c6102e>>
-
Import MEDIA_ROOT from django.conf settings instead. Refs
#830→ <<cset b63174578a6c>>
-
Adding # nosec to attempt to quell Codacy. Refs
#830→ <<cset b0dfce1d7c13>>
-
Attempt to stop PyLintPython3_E5142 error in Codacy - possibly a bug in the linting application? Refs
#830→ <<cset a6442e242586>>
-
reporter Merged in Ed-McDonagh/adding-nosec-to-attempt-to-quell-codacy-1605282391947 (pull request #421)
Adding # nosec to attempt to quell Codacy. Refs
#830Approved-by: David Platten dplatten@gmail.com
→ <<cset 2fdc63bd6392>>
-
reporter Merged in Ed-McDonagh/attempt-to-stop-pylintpython3_e5142-erro-1605282678339 (pull request #422)
Attempt to stop PyLintPython3_E5142 error in Codacy - possibly a bug in the linting application? Refs
#830Approved-by: David Platten dplatten@gmail.com
→ <<cset b0ec0e2e8433>>
-
reporter - changed status to resolved
Merged in issue830histogramChartProblem (pull request #419)
Issue830histogramChartProblem
Approved-by: David Platten dplatten@gmail.com Approved-by: Ed McDonagh ed@mcdonagh.org.uk
Fixes issue
#477Fixes issue#830→ <<cset dc01dd816939>>
- Log in to comment
I think this problem is being caused by a difference in sorting order between two lists in my charting Python code.
The Python charting code needs to be re-written so that a single object is returned from each chart type routine that has a sensible structure and makes this type of issue go away. The JavaScript will also have to be re-written.
The dilemma: do we fix this for the current charting, or do we address it at the same time as replacing Highcharts with something else?
@Ed McDonagh what do you think?