from pydicom.dataelem import isMultiValue doesn't work with pydicom 2.0
Comments (11)
-
reporter -
reporter Added ref
#838to changes.→ <<cset 253b171f6c8b>>
-
reporter Not the right hash ID at this point, but added test which unfortunately shows my changes don't work! Refs
#838→ <<cset 7ff6763a5e15>>
-
reporter I think I am going a little astray here.
hash_id
only applies to the patient name, ID, and accession number. Patient name cannot be multivalue (presumably), so I shouldn’t be trying to make this work. It should however handle the error better. -
reporter Happy now. Created name hash with Python 2.7, old pydicom, OpenREM 0.10; added test in this code; result matches. Also enabled multivalue names to be hashed without error. Refs
#838→ <<cset 1ae8789383b4>>
-
reporter Fixing Codacy identified issue. Refs
#838→ <<cset 1c4b2b4da40b>>
-
reporter Addressing more Codacy issues. Refs
#838→ <<cset f13dee312493>>
-
reporter Addressing more Codacy issues. Deleted replace_comma function as was unused. Refs
#838→ <<cset 06bcad7fe0f8>>
-
reporter Final Codacy issue. Refs
#838→ <<cset be7acbaaf46d>>
-
reporter - changed status to resolved
Merged in issue838multivalue (pull request #371)
Fixes
#838Approved-by: Luuk
→ <<cset c3e6fb4bb761>>
-
reporter Removing errant print statement that shouldn't be there. Refs
#838→ <<cset 924370f4c49c>>
- Log in to comment
Fixing concatenation of multivalue PersonNames for pydicom 2.0. Also for hashing Names, which might change matching of pre and post upgrade hashed names. Refs
#838.→ <<cset 1db37acf47eb>>