- edited description
Duplicate display names for GE OEC Fluorostar mobile fluoroscopy system
A GE OEC Fluorostar system has recently been configured so that DICOM RDSR objects can be sent to OpenREM. This works, but each study sent creates a new entry in the Display Name table. This seems to be because each study uses a different Device Observer UID. My understanding is that this field should be unique to the equipment, but for this system it changes for each study.
It is very unlikely that I will be able to change the data being sent from the system, so would like a solution built into OpenREM.
We could add a section to the local_settings.py:
IGNORE_DEVICE_OBSERVER_UID_FOR_THESE_MODELS = ['GE OEC Fluorostar']
Then in rdsr.py before the equip_display_name is created:
from django.conf import settings
if device_observer_uid in settings.IGNORE_DEVICE_OBSERVER_UID_FOR_THESE_MODELS:
device_observer_uid = None
May need to add the above into the other extractors too.
Thoughts?
Comments (23)
-
reporter -
Is it a maintained/current model? Might it be fixed in a future software release?
We’d need to add it to the .env.prod docket file too.
-
reporter The system is serviced by a third-party company. I have contacted them to report the issue, and asked for contact details of the manufacturer so I can report it directly.
-
reporter Added a setting to contain a list of equipment models where the Device Observer UID must be ignored when creating display name data during RDSR import. Refs issue
#908→ <<cset b228c5505959>>
-
reporter @Ed McDonagh would you like me to add this to the .env.prod file in the Docker repository?
-
Yes please. This is where it can get complicated… I think you should create a issue908ignoreDeviceObserverUID branch in that repo too, and if/when we merge in this repo, we remember to merge into develop in that repo too. Hmm. Not a pretty workflow.
-
reporter OK - done.
-
reporter Correcting error in logic: I need to see if the current RDSR is in the ignore list, not check if the device observer uid is in the list. Doh. I can confirm that this code works. Refs issue
#908→ <<cset 8a57c669560a>>
-
reporter Resolving conflict with changes.rst. Refs issue
#908→ <<cset 6268b2ae2018>>
-
reporter Addressing Codacy issues. Refs issue
#908→ <<cset 689cdfd37504>>
-
reporter Addressing Ed's comments on the documentation and link to the issue. Refs issue
#908.→ <<cset 45324d1e9524>>
-
reporter Removed reference to local_settings.py. Shorted line length in settings.py. Refs issue
#908→ <<cset 9d024d70952d>>
-
- changed status to resolved
Merged in issue908ignoreDeviceObserverUID (pull request #462)
Fixes
#908Approved-by: Ed McDonagh
→ <<cset eb48c7bf1d92>>
-
@David Platten I notice that this is in
settings.py
afterlocal_settings.py
is imported, and doesn’t exist inlocal_settings.py
I think maybe when you were implementing this we were just doing Docker, where the
local_settings.py
file was redundant?If I’m reading this right, I’ll move it up the
settings.py
file, add it tolocal_settings.py
file and modify the docs.I’ll reopen the issue for now so I don’t forget.
-
- changed status to open
Reopening to remember to make sure this is right before release (location of setting and docs) - see comment on 16th October 2022
-
- changed milestone to 1.0.0
-
Moved variable to above local_settings import. Added instruction from docker .env doc to i_displaynames. Referred to it from install docs. Refs
#908→ <<cset 2976ef70b97b>>
-
Adding to non-upgrade to new server section too. Refs
#908[skip ci] docs only→ <<cset 2feb5bd2cc4f>>
-
Added in-page ref to link. Refs
#908[skip ci] docs only→ <<cset d21ab672d6f8>>
-
reporter Good spot @Ed McDonagh . I’ve just noticed that my test 1.0 system has lots of display name entries and was wondering what was going on. I have just moved the settings.py variable so it is before the import of local settings, and expect that will fix it.
-
Can you review and approve the PR once you are happy?
-
reporter Approved - my test system is now working as expected
-
- changed status to resolved
Merged in issue908ignoreDeviceObserverUID (pull request #541)
Fixes
#908again :)Approved-by: David Platten
→ <<cset 963c2413402f>>
- Log in to comment