Add Radiopharmaceutical Radiation Dose Reporting
Comments (33)
-
-
reporter Awesome.
I would like the language one in there. It is only two items and they are both ForeignKeys to the ContextID table, the same as so many others such as https://bitbucket.org/openrem/openrem/src/25c7cfdaa4000a1003077b32be6f8cd8f581b185/openrem/remapp/models.py?at=develop&fileviewer=file-view-default#models.py-875
The Person Participant class is already there, so can just use it https://bitbucket.org/openrem/openrem/src/25c7cfdaa4000a1003077b32be6f8cd8f581b185/openrem/remapp/models.py?at=develop&fileviewer=file-view-default#models.py-1088
Anything that has a value multiplicity of more than 1 (ie 1-n) needs to go into its own table (Class). Which is how it all gets so complex!
-
TID1204 (language) would require a table on its own, but I'm happy to create it if you see any applications for it :)
I'll make a first attempt at implementing the RRDS models. Hopefully the applications and supporting devices will follow soon ;) -
reporter Sorry, yes, that is what I was thinking. One class/table, two fields.
I'll ask my NM colleagues if they have seen any evidence of them anywhere...
-
I just noticed that instead of defining yet another class/table, you added the columns of TID 1003 “Person Observer Identifying Attributes” directly to the ObserverContext class. Can I do the same for certain other classes (e.g. the language class above) to restrict the number of unnecessary tables?
Any ideas on how to deal with elements like "Activity Measurement Device" that appear two times? (http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_TID_10022.html)
-
What to do with:
- "Intravenous Extravasation Symptoms" (1-n) in http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_TID_10022.html
- "Patient state" and "Glomerular Filtration Rate" (both 1-n) in http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_TID_10024.htmlSkip?
-
reporter I think it is ok to combine them in the same table if they only appear together and 1:1. Hopefully that is the case for where I have done that!
I don't think I've come across an example like Activity Measurement. I think I would enter it twice with different but related names.
(I know I'm posting this after you have written more - I haven't read your updates yet!)
-
reporter I would put them in. Could be useful for various things. Simple short table, same as the grid one for example: https://bitbucket.org/openrem/openrem/src/25c7cfdaa4000a1003077b32be6f8cd8f581b185/openrem/remapp/models.py?at=develop&fileviewer=file-view-default#models.py-616
-
See pull request #69.
-
reporter Hi @tcdewit - I have just answered a google group question about this you might be interested in: https://groups.google.com/d/topic/openrem/MZmPNWxWU3Y/discussion
Also, the link at the top to the template is wrong now - here is the correct URL: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_RadiopharmaceuticalRadiationDoseSRIODTemplates.html. Your original link is missing an L in Radiopharmaceutical - I presume they noticed and added it in later!
-
reporter Merged in issue94AddRadiopharmModels (pull request #477)
Refs
#94Approved-by: Ed McDonagh
→ <<cset 8a6df13a0973>>
-
reporter These changes allow import to continue, but would create a new root. Refs
#94→ <<cset b0704b01f3bc>>
-
reporter Very minor changes to import order etc. Refs
#94.→ <<cset 33ce62fb6f07>>
-
reporter Merged in issue94fiximports (pull request #481)
Very minor changes to import order etc. Refs
#94.Approved-by: Jannis Widmer
→ <<cset 564a0bcc58f4>>
-
reporter Add comments as to which SOP Class IOD is which. Refs
#94sort of→ <<cset d365642f13ee>>
-
reporter Merged in issue94addIODtypecomments (pull request #483)
Add comments as to which SOP Class IOD is which. Refs
#94sort ofApproved-by: Jannis Widmer
→ <<cset c526aa385aa9>>
-
reporter Extra run of Black, tidying up my last PR plus minor change to rrdsr_methods.py. Refs
#94→ <<cset d64e2fc16ce7>>
-
reporter I’ve added the documentation branch to build on read the docs: https://docs.openrem.org/en/issue94documentation/
Also, if you are doing just documentation, you can add
[no ci]
to the commit to prevent build minutes being wasted as there are no tests on the docs.
-
reporter Have you got the date for the RRDSR and the CT RDSR very different @Jannis Widmer ? Does that matter? One is 2000 and one is 2022…
-
No it’s not a problem. I manually changed the date on the rrdsr back to 2000 to test something, they are actually from the same time.
-
reporter Renaming tests to reflect loading order, as per 21525c0. Refs
#94→ <<cset 18e56bde3c8c>>
-
reporter Merged in issue94AddNMExport (pull request #487)
Issue94AddNMExport - Adds excel and csv exporter for NM Refs
#94Merging to allow consideration of next PR!
Approved-by: Ed McDonagh
→ <<cset 8d31b8ba074e>>
-
reporter - changed milestone to 1.0.0
-
assigned issue to
-
reporter Changed sentence about PET images with RRDSR - have I got this right? Refs
#94[skip ci] docs only→ <<cset aba42561b2fa>>
-
reporter Added import script type of "nm" to docker orthanc lua script; adding the same to the import views side. Refs
#94.→ <<cset 7c8cddbae640>>
-
reporter Merged in issue94NMimportDocker (pull request #503)
Adding NM to docker import view. Refs
#94→ <<cset 1a399c7642d8>>
-
reporter Attempt to trim a few of the +88 issues. Refs
#94,#788,#934.→ <<cset 1d35a052b783>>
-
reporter Merged in issue94issue788issue934tidying (pull request #504)
→ <<cset 460d4b1bb85d>>
-
reporter Sonarcloud fixes. Refs
#94,#788.→ <<cset ecc9b4d14694>>
-
reporter A few more sonarcloud fixes. Refs
#94,#788.→ <<cset ac7c3ce2e37a>>
-
reporter Tidying up NM detail tables. Refs
#94.→ <<cset 43f38a455c89>>
-
reporter Updating changes with refs
#94,#788,#934, updating release notes. [skip ci] docs only→ <<cset 5aa12e5d8342>>
-
reporter - changed status to resolved
Merged in issue94issue788issue934Merge (pull request #500)
Issue94issue788issue934Merge
Fixes
#94,#788,#934, though there will be lots of docs revision to do.Approved-by: Ed McDonagh
→ <<cset ae758c3481e7>>
- Log in to comment
Format specified in: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_RadiopharmaceuticaRadiationDoseSRIODTemplates.html
I've already started adding the necessary classes to the models. Are there any includes/tables that you know can be skipped? (e.g. TID 1204 “Language of Content Item and Descendants” and TID 1020 “Person Participant”). That would save me some time.
Any clues what to do with multiple Observer Contexts in one class? (see http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_TID_10022.html : Observer Contexts and Activity Measurement Device)