Upgrade pyasn1

[Oleksandr Maksiuta]

Hi I try to use last go-docker:dev image, but have some problem. LDAP authorization not work.

=============================

2018-10-26 06:49:53,221 ERROR [yapsy][MainThread] Unable to import plugin: /opt/go-docker/plugins/goauth Traceback (most recent call last): File "/usr/local/lib/python3.5/dist-packages/yapsy/PluginManager.py", line 488, in loadPlugins candidate_module = imp.load_module(plugin_module_name,plugin_file,candidate_filepath+".py",("py","r",imp.PY_SOURCE)) File "/usr/lib/python3.5/imp.py", line 234, in load_module return load_source(name, filename, file) File "/usr/lib/python3.5/imp.py", line 172, in load_source module = _load(spec) File "<frozen importlib._bootstrap>", line 693, in _load File "<frozen importlib._bootstrap>", line 673, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 673, in exec_module File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed File "/opt/go-docker/plugins/goauth.py", line 5, in <module> from ldap3 import Server, Connection, SUBTREE File "/usr/local/lib/python3.5/dist-packages/ldap3/init.py", line 138, in <module> from .core.connection import Connection File "/usr/local/lib/python3.5/dist-packages/ldap3/core/connection.py", line 37, in <module> from ..extend import ExtendedOperationsRoot File "/usr/local/lib/python3.5/dist-packages/ldap3/extend/init.py", line 45, in <module> from .standard.whoAmI import WhoAmI File "/usr/local/lib/python3.5/dist-packages/ldap3/extend/standard/whoAmI.py", line 27, in <module> from pyasn1.type.univ import NoValue ImportError: cannot import name 'NoValue'

=====================================

after manual upgrade package pyasn1 all works fine.

root@60fa34bb7bf4:/opt/go-docker/plugins# pip3 install --upgrade pyasn1 Collecting pyasn1 Downloading https://files.pythonhosted.org/packages/d1/a1/7790cc85db38daa874f6a2e6308131b9953feb1367f2ae2d1123bb93a9f5/pyasn1-0.4.4-py2.py3-none-any.whl (72kB) 100% |################################| 81kB 847kB/s Installing collected packages: pyasn1 Found existing installation: pyasn1 0.1.9 Not uninstalling pyasn1 at /usr/lib/python3/dist-packages, outside environment /usr Successfully installed pyasn1-0.4.4

Please, upgrade this pacckage.

Thanks a lot, BR, Oleksandr

[Olivier Sallou]

humm.... problem is pyasn1 is not a "direct" dependency, I cannot upgrade it as it is not in requirements.txt It is a dependency of ldap3 which is not itself pinned to a specific version, so it should have installed latest....

ldap3 requirement is pyasn1>=0.1.8 , so it fits and should have worked and I see no recent pyasn package update.

I tried to pull latest osallou/godocker:dev and looked at installed packages and found:

root@91c4f26fde28:~# pip freeze > /tmp/out
root@91c4f26fde28:~# egrep ldap3 /tmp/out
ldap3==2.5.1
root@91c4f26fde28:~# egrep pyasn /tmp/out
pyasn1==0.1.9

don't know why pyasn1 version is not latest....

[Olivier Sallou]

seems that during build pyasn1 is found at some acceptable version (>= 0.1.8) so it does not upgrade it.

Issue should be forwarded to ldap3 package to ask them to force for a later pyasn dependency.

python-pyasn1 is indeed pre-installed on Debian OS at older version.

In the meanwhile, in docker build file, I can force the upgrade of pyasn1 (expecting there is no side effect)

[Olivier Sallou]

force in Docker an upgrade of pyasn1, default is too old and create an error, closes #82

→ <<cset 2c5b6a3b1dfc>>

[Oleksandr Maksiuta]

Hi, For ldap3==2.5.1 we have some information about pyasn1 https://ldap3.readthedocs.io/changelog.html

fixed an exception while logging packet with pyasn1 decoder

[Olivier Sallou]

I have forced in container the upgrade for pyasn1, :dev container has been updated