Shall we use DROP IF EXISTS in the "export SQL"
Issue #303
resolved
In the "export SQL" view, there is an option "Add DROP TABLE". In the exported file, it shows DROP TABLE xyz However, if user drop table xyz and then import the sql it will throw exception saying that table xyz does not exist. Thinking that if we use DROP IF EXISTS, it will be safer to import the sql file
I can open a pull request if there is no concern :)
Comments (6)
-
-
-
- changed status to open
-
reporter
@crazy4chrissi pull request created: https://bitbucket.org/phpliteadmin/public/pull-requests/2/use-drop-if-exists-in-the-export-sql/diff
-
- changed status to resolved
Merged in weelyoung/phpliteadmin/dev1 (pull request #2)
use DROP IF EXISTS in the "export SQL"
Fixes issue
#303→ <<cset 5e023837c341>>
-
-
assigned issue to
Christopher Kramer
Thank you.
-
assigned issue to
- Log in to comment
Agreed. Please open a pull request, I will include it. (Please make sure you don't make any unnecessary indention changes in your commit - we use tabs, not spaces for indention)