MessageDeliveryReceiptsManager sends message receipts with wrong type

[Vitaly Takmazov]

https://bitbucket.org/sco0ter/babbler/src/a0c9df4abe6c650fe81f92db67579c2332ac8f30/xmpp-extensions/client/src/main/java/rocks/xmpp/extensions/receipts/MessageDeliveryReceiptsManager.java?at=master&fileviewer=file-view-default#MessageDeliveryReceiptsManager.java-93

why NORMAL? %) I think there should be message.getType()

[Christian Schudt]

The type is not specfied in XEP-0184. I think I even brought this up in the XMPP mailing list.

There's only one example, which lacks the type completly, meaning it is implicitly type "normal".

[Vitaly Takmazov]

Agreed about XEP should be clarified, but normal messages are very rare used in XMPP-IM and existing IM clients often show completely different UI for normal messages and may be confused with changed type.

[Christian Schudt]

Convinced me. XEP-0184 has a subtle hint, too:

the sender would receive one ack message from each occupant of the room

implies that ack message are of type="groupchat"

[Christian Schudt]

Receipt messages should have the same type as the request message instead of normal type.

Fixes issue #133

→ <<cset f39062ffedd6>>

[Christian Schudt]

Fixed with version 0.8.0