- changed status to resolved
Misleading docs for TruncatedBinaryExponentialBackoffStrategy
Issue #67
closed
Docs of both TruncatedBinaryExponentialBackoffStrategy#getNextReconnectionAttempt() and ReconnectionManager say that the intervals end at 60, 180, etc. Actually this is incorrect: As the unit test TruncatedBinaryExponentialBackoffStrategyTest proofs the intervals are exclusive-end, so the actual ends are 59, 179, etc.
This is misleading. The docs should get improved to be clear.
I could send a PR but just wanted to ask whether this really is a doc bug, or whether the implementation / test is wrong (and SHOULD provide 60, 180, etc. actually)?
(Version is 0.7.0-SNAPSHOT, but Bitbucket does not allow me to type that into version field)
Comments (3)
-
repo owner -
repo owner I think you are right, the JavaDoc was off for 1 second.
-
reporter - changed status to closed
Thanks for fixing the docs. :-)
- Log in to comment
Improve JavaDoc for TruncatedBinaryExponentialBackoffStrategy.java
Fixes Issue
#67→ <<cset 3ffb4a529ea5>>