MIEMIS rollover 2022 not working

[Ghislain Hachey]

Some invalid cast type exception

[Ghislain Hachey]

There are two issues”

• Data cast error when pulling date data from the XML data row. This was not happening with Date_Of_Birth since it strictly build the new rolled over excel from tDOB. However, it sooner or later fails on Date_Of_Hire, Date_of_Exist in case where the coalesce tries to pick up data from the XML. A quick fixed will be pushed to do like Date_of_Birth: only get data from the TeacherIdentity (tPSDateAppointed for Date_of_Hire and tPSDateAppointedClosed for Date_of_Exit)
• The other issue is that the rollover fails silently when there is not Survey record for the coming year being rolled over into. This is related to #924. It needs a more graceful user feedback and easy way to create this new survey year.

‌

[Ghislain Hachey]

The fix to the first issue described above is not needed to get the rollover working. However, a less important note: it would seem that the following code in [pSurveyOps].[censusRolloverStaff] is unnecessary as the date conversion raises an error so data only goes it the new workbook when it exists in tDatePSAppointed.

, coalesce( TI.tDatePSAppointed
, nullif(ltrim(v.value('@Date_of_Hire', 'nvarchar(100)')),'')
, nullif(ltrim(v.value('@Date_of_Hire_', 'nvarchar(100)')),'')
) [Date_of_Hire]

And is in fact the same result as having

, TI.tDatePSAppointed [Date_of_Hire]

‌

[Ghislain Hachey]

Turned out the fix for the issue bullet 1 above was in fact needed otherwise the rollover fails silently because of a cast type error. The SQL fix in the stored procedure is pushed being pushed into production with comments.

[Brian Lewis]

fix(workbook): Fix invalid cast on school budget; similar #1224

Resolves #1224

→ <<cset f2a5b154948e>>