School Chart bugs

Issue #125 resolved
Brian Lewis repo owner created an issue
  • province doesn't work when selected for Column
  • there is no default for Row when first opened

Comments (11)

  1. Brian Lewis reporter

    This occurs when there is a vocab entry for District that is different ie Province, Its matching on the wrong thing.

  2. Brian Lewis reporter

    Resizing seems no longer to work. ie the chart does not fill its pane.

    Also, we need to check the contents of various dropdown lists in the filter - School Type is empty,

    This does need some investment of effort to repair.

  3. Ghislain Hachey

    I have public/private for school type (which is really school class in the background). This was the provide the quickest way to get them the public/private filter they wanted.

    I'm lowering priority for everything in here. While it is important it is not currently critical.

  4. Brian Lewis reporter

    Resizing: the logic of getSize -> newSize ->onREsize in SizableComponentController works effectively, but the issue has been that it does not always run, the $watch expressions don;t run if there is no Digest.

    So the problem becomes - how to force a digest when there has been a change that could affect size?

    So two things have been done

    1) trigger a $timeout() in the main app controller on $window resize. This catches changes to the browser window - including landscape-to-portrait rotate on a phone/tablet

    2) on change of a global setting - this is to catch the appearance disappearance of the popout navigation bar

  5. Brian Lewis reporter

    Other fix - for data content not changing with filter parameters, is in the data layer.

  6. Log in to comment