softwords / pineapples / issues / #480 - tidy dcCharts abstraction — Bitbucket

Issue #480 closed

Jeremy Kells created an issue 2018-09-23

Refactor dcCharts code to make abstraction stronger.

Rather than reaching into dcCharts component, and then it's wrapped d3 chart component to modify it's filters, dcChart components now receive the filter as a parameter.

Comments (3)

Brian Lewis repo owner
Please provide a description of the issue, proposed change, motivation.
- 2018-09-23T04:04:51+00:00
Jeremy Kells reporter
- edited description
- 2018-09-23T04:30:35+00:00
Brian Lewis repo owner
- changed status to closed
refactor(Dashboards) Clean up dcCharts abstraction

Filters work via binding

closes ~~#480~~

→ <<cset f50a0f76acd8>>
- 2018-09-24T22:52:29+00:00
Log in to comment

Assignee: –

Type: bug

Priority: minor

Status: closed

Votes: 0

Watchers: 1

Jira: the preferred issue tracker for Bitbucket. Join the team!