Close button does not work in all dialogs

Issue #967 resolved
Brian Lewis repo owner created an issue

This is due to an inconsistency fro earlier code in the use of

ControllerAs: “dvm” (“Dialog View Model”)

vs

ControllerAs: “vm” (“View Model”)

dvm doesn;t give us anything, and leads to some conflicts in markup between components that share a template (MaterialDialoogLayout)

Get rid of dvm in the remaining plaves it appears:

Find all ""dvm"", Subfolders, Find Results 1, "D:\Files\vsprojects\pineapples\Pineapples.Client\src", "*.ts"
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\Indicators\Indicators.Component.ts(56):        controllerAs: "dvm",
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\School\SchoolSurveyList.Component.ts(31):        controllerAs: "dvm",
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\Student\StudentEnrollmentList.Component.ts(24):    //    controllerAs: "dvm",
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\Student\StudentScoreCardList.Component.ts(24):        controllerAs: "dvm",
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\Teacher\TeacherAppointmentList.Component.ts(24):        controllerAs: "dvm",
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\Teacher\TeacherPayslipList.Component.ts(24):        controllerAs: "dvm",
  D:\Files\vsprojects\pineapples\Pineapples.Client\src\app\ts\features\Teacher\TeacherSurveyList.Component.ts(24):        controllerAs: "dvm",
  Matching lines: 7    Matching files: 7    Total files searched: 359

Also check fro ClickOutsideToClose is a default on all material dialogs ( unless there is a good reason to force an explicit response)

Comments (2)

  1. Brian Lewis reporter

    sent as individual commits for each dialog so it is easier to see exactly what was affected - commit has the dialog definition (.ts and its corresponding template (.cshtml)

  2. Log in to comment