(wrong) assumptoin about page size?
Issue #15
resolved
what do these constants mean?
ExportDelta = ((DOSHeader->e_lfanew + PEHeaderSize) / 0x1000) * 0x1000;
(there are many more cases)
Kindly add a short comment what that this is supposed to mean. If it is the page size, we should probably query it from the system, not hardcode it.
Comments (3)
-
reporter -
lol no idea. we should remove the /0x1000 * 0x1000
-
- changed status to resolved
kind of fixed Issue
#15https://bitbucket.org/mrexodia/titanengine-update/issue/15/wrong-assumptoin-about-page-size→ <<cset 829c0e77ba00>>
- Log in to comment
also, they seem redundant here.