enginehandleclose

[deep zero]

what is the purpose of calling engine handle close? Why not call CloseHanlde() directly?

and: shouldnt this: HandleFlags!=HANDLE_FLAG_PROTECT_FROM_CLOSE)

be a flag check?

[Duncan]

resolved issue #29

→ <<cset d8f86da5ff32>>

[Duncan]

i think EngineHandleClose is some sort of relic, I dont know the exact purpose

[Carbon Monoxide]

You are right. This is a flag, the check is wrong.

This is only useful inside the debugger loop to close non-titanengine handles. We should close all self-created handles directly with CloseHandle.

[Carbon Monoxide]

fixed wrong

[Duncan]

no, its fixed correctly..

[Carbon Monoxide]

this is correct: (HandleFlags&HANDLE_FLAG_PROTECT_FROM_CLOSE)!=HANDLE_FLAG_PROTECT_FROM_CLOSE

[deep zero]

ah! I KNEW something was wrong. :)

[Duncan]

haha, you're right indeed I reversed the purpose.

[Duncan]

resolved issue #29

→ <<cset dcfd71b68d8b>>