cmake 3.10
Issue #3
closed
If you build in linux with cmake 3.10 you need to set the cxx standard to 11 in CMakeLists.txt set(CMAKE_CXX_STANDARD 11)
Comments (5)
-
repo owner -
repo owner - changed status to open
I'll try this also with clang. But the main issue of setting CMAKE_CXX_STANDARD to 11 is already in src/Vector/BLF/CMakeLists.txt for the library.
-
repo owner This issue is solved in v1.1.2 in the following commit: https://bitbucket.org/tobylorenz/vector_blf/commits/2870ca02deb11b2769b2e8fe820eedd6eb947031
Indeed the CXX_STANDARD_REQUIRED was wrongly used. In addition CXX_EXTENSIONS and gcc pedantic flag have been added.
The same change need to be done in all other projects as well.
-
repo owner - changed status to closed
-
repo owner -
assigned issue to
-
assigned issue to
- Log in to comment
Using "set" does this on a global level. Actually the more modern way is to use "set_target_properties" and if you look in src/Vector/BLF/CMakeLists.txt, this is already done for the library.
It's not done for the depending targets, such as the parser yet, because my assumption was that the C++11 setting is inherited automatically from the library. And this assumption seems to be true in my builds. So it might be that this is also clang-related, as you mentioned in issue
#4.