Wrong assumptions

Good health to you, TorMec!

Your new code is better :).

Still, it's wrong.

Firstly, there is no such thing as "standard directory to install DokuWiki". It can be installed in various places, in various OS.

Secondly, you shouldn't assume that people use something "standard".

But this string is based on such assumption:

$dir = DOKU_INC . ltrim($conf["savedir"], "./") . "/pages";

As DW docs say, $conf["savedir"] can be full path, and in that case your code fails again.

Instead of taking fantasies for truth, you should make sure the code works with any possible data. You should think and understand which data can actually be there.

In this case, docs say there is $conf['datadir'], which actually shows the place of those .txt files. It can be './data/path/', but also it can be './hello/snusmumrik/'.

So what you should write there is:

$dir = realpath($conf['datadir']);

See realpath() in PHP manual.

Also, when you do such tasks, it's useful to search how others do such things.

Then you could learn elegant programming and discover many caveats.

See this string:

$sidebar = implode("/", array(str_replace(":", "/", $ns), $conf["sidebar"]));

implode is useful to automatically join many pieces. In case of few pieces you should just join them with "." (string concatenation operator):

$sidebar = str_replace(":", DIRECTORY_SEPARATOR, $ns) . DIRECTORY_SEPARATOR . $conf["sidebar"];

Use DIRECTORY_SEPARATOR constant instead of "/", because in Windows for example it's "\", not slash. So if you compare strings with different separators, your code would fail.

https://secure.php.net/manual/en/dir.constants.php

By the way, think about writing simple code.

Instead of

                if (file_exists($dir . "/" . $sidebar . ".txt")) {
                    $ns_acmenu = $ns;
                    break;
                }

write

                if (file_exists($dir . "/" . $sidebar . ".txt")) return $ns;

and the last string return $ns_acmenu; should be replaced with

return "";

Variable $ns_acmenu isn't needed at all.

I hope you could learn to program in a safe and simple manner, and would do many useful things for people.

Good bye!

Comments (5)