File colision with non-namespaced headers

[Matthew Thode]

usr/include/alg_sig.h
usr/include/xor_code.h
usr/include/xor_hd_code_defs.h
usr/include/list.h

list.h is my specific issue here, but can the others be namespaced as well?

Here's the downstream bug if you want it. https://bugs.gentoo.org/show_bug.cgi?id=549048

[Kevin Greenan]

@tsg- Do you have time for this? If not, I can try and do it early next week. Should be pretty easy.

We should also fix this before tagging the next minor version.

[Kevin Greenan]

@tsg-

I think this can be dealt with pretty easily with:

diff --git a/Makefile.am b/Makefile.am
index f442ecf..21a5f0f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -14,7 +14,8 @@ AM_CPPFLAGS += -Werror -Wall

 AM_CFLAGS = -fPIC $(AM_CPPFLAGS) @GCOV_FLAGS@ -L/usr/local/lib

-include_HEADERS = \
+thisincludedir = $(includedir)/liberasurecode
+thisinclude_HEADERS = \
        include/erasurecode/alg_sig.h \
        include/erasurecode/erasurecode.h \
        include/erasurecode/erasurecode_backend.h \

We can also remove 'list.h' from the list of header file to install, since there is no reason to export it to users of liberasurecode. In fact, we should probably cull the existing list to only include header files needed by applications using liberasurecode.

Make sense?

[Kevin Greenan]

This should fix Issue #17, which will place the liberasurecode headers into their own subdir, to avoid naming collisions with header files.

→ <<cset f0f27ee85aaa>>

[Tushar Gohad]

@kmgreen2 agreed this should be in 1.0.8. Does this eliminate list.h inclusion from the installed set though? The other way ofcourse would be to make sure to prefix all headers with erasurecode_ per original suggestion.

[Tushar Gohad]

@kmgreen2 never mind. :) "thisincludedir" change should do it for this one! Thanks for taking care of this issue.

[Kevin Greenan]

Fixing issue #17 to namespace header files.

→ <<cset 1118acd6451d>>