test: Add checks for EBACKENDNOTAVAIL

Issue #6 closed
Tushar Gohad repo owner created an issue

Backend libraries not being available is causing errors like in tests that are missing these checks:

ok 1 - test_create_backend_invalid_args: UNKNOWN lt-liberasurecode_test: liberasurecode_test.c:276: test_destroy_backend_invalid_args: Assertion `desc > 0' failed. make: *** [test] Aborted (core dumped)

Comments (5)

  1. Tushar Gohad reporter

    test: Add missing EBACKENDNOTAVAIL checks

    Without these checks, backend libraries not being available is causing errors like in tests that are missing these checks:

    $ make test [snip] ok 1 - test_create_backend_invalid_args: UNKNOWN lt-liberasurecode_test: liberasurecode_test.c:276: test_destroy_backend_invalid_args: Assertion `desc > 0' failed. make: *** [test] Aborted (core dumped)

    Closes issue #6

    → <<cset b6851e829def>>

  2. Tushar Gohad reporter

    @bloodeagle40234 @kmgreen2 this should fix the errors we have been seeing on ubuntu with backends not being available. Can you confirm this works for you when you remove all references to libJerasure, libnull etc.

  3. Kota Tsuyuzaki

    @tsg- ya, I confirmed the <<cset b6851e829def>> doesn't show the error when no backends are available. However, I still wonder it is really better because, if we didn't install libnull backend at least, the tests seem to do almost nothing... Could we be able to ensure "make install" before "make test" as a testing procedure?

  4. Tushar Gohad reporter

    @bloodeagle40234 "make test" needs to test local changes and not "installed" changes. So that may not work ..

  5. Kota Tsuyuzaki

    @tsg- Oh, sorry. I didn't notice 93446db9414f311bd9fc7dc047eb4dbbeb3e6feb change which ensures "make test" to check local changes.

    When I tried the above commit to run "make test" without install again, it worked well so that I think "you are right and your change works well under your intention". Sorry for my lack to understand.

  6. Log in to comment