Repeating pattern in noise

[Robert Thompson]

Hi David,

The random noise you apply to the shader creates a repeating pattern on the landscape (as in the picture attached). It may not be noticeable when generating landscapes but I figured i'd mention it anyways.

Looks like this change may be the source.: https://bitbucket.org/volumesoffun/cubiquity-for-unity3d/commits/f29bc476eeed17f10156c8e3e47df7957ec49d2b

Ell

[David Williams]

Actually I think this repeating pattern did exist before, but it has become much more visible with the change you mention. But the change was necessary in order to make the noise properly stick to the surface when the volume is being transformed.

I think the real problem is that my random number generation for the noise is not very good (a surprisingly tricky problem on the GPU), and actually has some built in repetition to fight precision problems. But I think I can do better :-) I'll try to take another crack at it.

[David Williams]

Ok, I think it should work significantly better now and will only repeat every few hundred voxels (which shouldn't be noticeable). Thanks for encouraging me to fix this properly :-)

[Robert Thompson]

Thanks David, I'll grab the latest version tonight and have a look.

[Robert Thompson]

Looks much nicer! no discernible repeating pattern now. Cheers.