Unbinding "previous weapon" via controller configuration causes a crash

[Samara Jinnah]

Steps to reproduce:

1. Revert your settings to the default by deleting or renaming your sphereFACE.cfg (you can find it in Steam/steamapps/common/sphereFACE/)
2. (Optional) Have an Xbox 360 controller plugged in
3. Hit ESC
4. Go to Options > Controls
5. Select "Configure" under "Controller Configuration" on the Controller menu
6. Edit the "Custom 1" configuration by selecting the button labeled by the same name
7. Unbind "Previous Weapon" by right clicking it

Also, attempting to bind Fire to the "A" button causes a segfault (you need a controller for this one).

[Riot]

What's a CTD?

[Samara Jinnah]

On Windows, the former bug causes an instant close (Crash To Desktop), while the latter causes the game to freeze until the operating system opens the familiar "{program_name} has stopped working" which gives the option to close the game. I thought that the difference in the way that it crashes was relevant, but it seems that both sets of actions cause a segfault on Linux.

[Hasan Ibraheem]

Can confirm on Arch Linux. It just crashes. I run from command line and got this output.

DEBUG: Added joystick control binding set "CUSTOM 1", new set size 3
DEBUG: Reconfiguring joystick control binding set "CUSTOM 1" of set size 3
InputStorm: Calibrating for capture
ALSA lib pcm.c:8321:(snd_pcm_recover) underrun occurred
ALSA lib pcm.c:8321:(snd_pcm_recover) underrun occurred
./start_linux.sh: line 16: 24208 Segmentation fault      "$executable"

[Samara Jinnah]

made instructions more clear

[Riot]

Able to reproduce.

[Riot]

replace cached unbind update list with a proper queue of bindings to update after control unbind, and adding hash function specialisations to support set insertion - resolves #372

→ <<cset 1598cb341fc3>>