Naming of waypoint labels

[Jens-Uwe Grooß]

If waypoints are created by the insert button, they are labelled as letters 'A', 'B', etc. If then the location is changed (by mv button or editing the table view coordinates), the label changes to numbers (no Location label in the table view). This is somewhat confusing, and I would suggest leaving out the automatic creation of the label letters.

[Joern Ungermann]

The current behaviour is a probably incomplete try to have more persistent names of waypoints. Using just number, waypoint names change if the path is modified before the current waypoint. DLR-FX requires waypoint names to persist between different versions of flightplans in case that the coordinates did not change. This was realised by giving new waypoints letter as names that are associated with the coordinates and could then be selected in the drop down field for further waypoints passing through the same coordinates. Moving a waypoint obviously changes the coordinates and thus would require a new name. The current implementation is faulty in the respect that a moved waypoint is not assigned a new letter/dummy name.

So I would set the requirements to be:

• A label should be associated with fixed lon/lat coordinates
• Moving a waypoint to a different lon/lat coordinate should discard the current label
• Moving a waypoint to a labeled location should use the label
• Labels should be persistent on a per-flighttrack basis

More questionable are the following requirements as they could be solved by proper user intervention (i.e. manually labeling waypoints before communicating the flight plan):

• Waypoints should be given unique, unchanging labels (currently semi-implemented for insertiong, but not coordinate change)
• One might include some "magnetic" shift towards labeled locations when moving locations with the mouse

[Jens-Uwe Grooß]

I think, that indeed it is confusing, if a waypoint label of a later flightpath version would change. However, I see no easy way, how this could be overcome in a satisfactory way. If we keep all labels as letters during the internal discussion wherever we first put a potential way point, we may end up with some non-alphabetical unsorted mix of letters. The user may be aware of this problem and we could leave this labelling issue to the responsibility of the user.

A "magnetic" shift would be useful, especially if the ICAO waypoints with distinct label names are present in the data base. But I do not know, how difficult the realisation of this will be.

[Joern Ungermann]

Okay, I'll prepare a PR fullfilling my requirements removing the automatic ABC labels given on insertion. Implementing a magnetic shift should be easy. If one would add the ICAO waypoints to the JSON config file, this would automatically work. If we can somehow save defined-but-currently-unused labels in the FTML file, I cannot say without further investigation. We can then see if the new behaviour is satisfactory.

[Reimar Bauer]

Remove assignment of letter labels and use label if coordinates agree

See issue #161

→ <<cset 531ed53eedbc>>

[Reimar Bauer]

Draft of "magnetic" locations in waypoint move in TopView.

See issue #161

→ <<cset 3974d286360f>>

[Reimar Bauer]

Made point insertion magnetic

Also adjust threshold according to plot size.

Resolve issue #161

→ <<cset 7b10e1ac7853>>