mswms crashes by wrong URLs for py3

Issue #339 resolved
Joern Ungermann created an issue

In my current py3 setup, the mswms is first triggered with an "empty" request before the getCapability request. This causes the following issues, crashing the thread:

a) The request is a None, which has no "lower" attribute. b) The default return value is a unicode string instead of a byte string. I.e. the empy string needs to be "encoded".

Comments (8)

  1. Reimar Bauer

    this has not a request attribute in the querystring, the correct Url with parameters is

    http://localhost:8081/?service=WMS&request=GetCapabilities&version=1.1.1

  2. Reimar Bauer

    If we want to hide the url parameters, we should verify that the Url is not a redirect and then add the missing paramters within the "get capabilities" click.

    Anyway we have to verify that only valid Urls proceed with the application and all others become ignored and logged.

  3. Joern Ungermann reporter

    The WMS client accesses the WMS URL without any parameters to identify a potential redirection. This behaviour is questionable and might be changed. I would not add any parameters to the URL that are not supplied by the client. In fact some kind of error code would be better suited for the case where no valid request ist given.

    In effect, I think this is the same issue as 342.

  4. Reimar Bauer

    We have to verify if all these GET parameter calls are mandatory. Probably they can be send by POST too.

    If POST is possible we may be should send all parameters by this. This gives a short Url/Path. -> 1.8.0

  5. Log in to comment