- edited description
Top View Map Appeareance options not defined with web map services
Issue #401
resolved
The options form of TopView has elements which can't be used when images from a web map services used.
- [ ] fill map background Color
- [ ] fill continents Color
We have to disable these elements for this usecase.
Comments (15)
-
reporter
-
Working on this.
-
@ReimarBauer Can you check if "fill map background" is setChecked(True) and disabled in develop branch in your local too?
-
Basically I have to take care of just "fill continents" right?
-
reporter
Only the color for the waypoints is handled by the gui.
fill map background is disabled, but the color box chooser right of it not.
-
reporter
thought I had seen continents filled, but not in that example.
-
So an ideal functionality would be, to 1. uncheck 'fill map background' and disable 'fill continents' when wms connected 2. check 'fill map background', and enable 'fill continents' when wms disconnected.
-
reporter
yes, that should be a small change.
If possible try to find the changesets which had added this feature. It looks like half implemented, if there is no option to call those images with different colors from the server. May be it was and now the problem is on another part of the codebase.
Then it depends on the amount of changes to get that working again for fixing in stable.
-
Sure will explore more before making a PR.
-
grep -nr "cbFillWaterBodies" . Binary file ./mslib/msui/qt5/__pycache__/ui_topview_mapappearance.cpython-37.pyc matches ./mslib/msui/qt5/ui_topview_mapappearance.py:31: self.cbFillWaterBodies = QtWidgets.QCheckBox(MapAppearanceDialog) ./mslib/msui/qt5/ui_topview_mapappearance.py:32: self.cbFillWaterBodies.setEnabled(False) ./mslib/msui/qt5/ui_topview_mapappearance.py:33: self.cbFillWaterBodies.setMinimumSize(QtCore.QSize(145, 0)) ./mslib/msui/qt5/ui_topview_mapappearance.py:62: self.cbFillWaterBodies.setPalette(palette) ./mslib/msui/qt5/ui_topview_mapappearance.py:63: self.cbFillWaterBodies.setChecked(True) ./mslib/msui/qt5/ui_topview_mapappearance.py:64: self.cbFillWaterBodies.setObjectName("cbFillWaterBodies") ./mslib/msui/qt5/ui_topview_mapappearance.py:65: self.horizontalLayout.addWidget(self.cbFillWaterBodies) ./mslib/msui/qt5/ui_topview_mapappearance.py:160: self.cbFillWaterBodies.setText(_translate("MapAppearanceDialog", "fill map background")) Binary file ./mslib/msui/__pycache__/topview.cpython-37.pyc matches ./mslib/msui/topview.py:81: self.cbFillWaterBodies.setChecked(settings_dict["fill_waterbodies"]) ./mslib/msui/topview.py:108: "fill_waterbodies": self.cbFillWaterBodies.isChecked(), ./mslib/msui/ui/ui_topview_mapappearance.ui:43: <widget class="QCheckBox" name="cbFillWaterBodies">grep -nr "fill map background" . Binary file ./mslib/msui/qt5/__pycache__/ui_topview_mapappearance.cpython-37.pyc matches ./mslib/msui/qt5/ui_topview_mapappearance.py:160: self.cbFillWaterBodies.setText(_translate("MapAppearanceDialog", "fill map background")) ./mslib/msui/ui/ui_topview_mapappearance.ui:145: <string>fill map background</string>I believe this has no dependent code snippet. It might be half-implemented. I will PR the simple update.
-
Also, this change(enabling and disabling of check-boxes), should they happen after 'get_capabilities' or 'first getmap'
-
reporter
we do it as early as possible, so after 'get_capabilities' is the better place.
-
reporter
- changed milestone to 1.8.0
The options form of TopView has elements which can't be used when images from a web map services used.
- [ ] fill map background Color
- [ ] fill continents Color
We have to disable these elements for this usecase.
-
reporter
- changed status to resolved
-
reporter
- changed title to Top View Map Appeareance options not defined with web map services
The options form of TopView has elements which can't be used when images from a web map services used.
- [ ] fill map background Color
- [ ] fill continents Color
We have to disable these elements for this usecase.
- Log in to comment
