GetCapabilities&version= version string ignores

[Reimar Bauer]

It looks like we could enter any version string but only ‘1.1.1' gets used

mandatory is currently only

/?request=GetCapabilities

[Reimar Bauer]

It looks like we could enter any version string but only ‘1.1.1' gets used

mandatory is currently only

/?request=GetCapabilities

[Joern Ungermann]

The 1.1.1 specification states:

7.1.3.1 Request Parameters

VERSION

The optional VERSION parameter, and its use in version negotiation, is specified in the Basic Service Elements section.

In WMS version 1.0.0, the name of this parameter was "WMTVER". That name is now deprecated, but for backwards compatibility and version negotiation a post-1.0.0 server shall accept either form without issuing a Service Exception. In the case that VERSION and WMTVER are both given, VERSION takes precedence.

‌

7.1.3.3 REQUEST

This nature of the required REQUEST parameter is specified in the Basic Service Elements section. To invoke the GetCapabilities operation, the value "GetCapabilities" shall be used. In WMS version 1.0.0, the value of this parameter was "capabilities". That value is now deprecated, but for backwards compatibility a post-1.0.0 server shall accept either form without issuing a Service Exception. When a client is initially contacting a WMS whose version it does not know the Client should be prepared to recover if REQUEST=GetCapabilities fails and may send REQUEST=capabilities.

[Joern Ungermann]

I interpret the specification that a missing version field should not generate an exception. If present it should match, I think.

And we might relax the check on getcapabilities to also accept capabilities.

“Service” is required and the proposed changes are fine in that regard.

[Reimar Bauer]

version in the specs is optional. We don’t support all versions. For the changes on that part I have no problem if someone requests 1.3.0 and gets nothing back until it is implemented. If someone enters no version number and gets only 1.1.1 back, well not our failure.

Good catch for capabilities :)

[Joern Ungermann]

I think you describe the intended functionality.

The service=wms is required to allow multiple different services to be offered on the same URL. Doesn’t seem to be urgent, though, for our typical MSS Server setup.

[Reimar Bauer]

service=wms have to become implemented on client side too. This part and also the refactoring will be a new issue. That failure is likly from the beginning there.

[Reimar Bauer]

checks query_string paramters, fixes #411

→ <<cset 0cbfba140b8b>>

[Reimar Bauer]

Merged in ReimarBauer/mss/i411 (pull request #645)

checks query_string paramters, fixes #411

Approved-by: Joern Ungermann [e-mail]

→ <<cset fbd6b8a6ed2e>>