mss pyui crashes when quitting

When MSS is quit without opening an msolab window it crashes with the error message:

Fatal error in MSS 1.9.0 on Linux-4.19.0-6-amd64-x86_64-with-debian-10.1
Python 3.7.4 (default, Aug 13 2019, 20:35:49) 
[GCC 7.3.0]

Please report bugs in MSS to https://bitbucket.org/wxmetvis/mss

Information about the fatal error:

Traceback (most recent call last):
  File "mss_pyui.py", line 424, in closeEvent
    if self.mscolab_window is not None:
AttributeError: 'MSSMainWindow' object has no attribute 'mscolab_window'

I think it should also crash in case that the mscolab window was first opened and then closed - it didn’t when testing for this just now, but I do not see how the reference to the window is set to none by anybody.

‌

I deem this critical as every “normal” user will experience this crash undermining the trust in the software.

Comments (8)