Test if message's text field is saved properly

[Shivashis Padhi]

https://bitbucket.org/wxmetvis/mss/src/4e2c48bf518137fe3e31a9d581672502d6836c7e/mslib/mscolab/_tests/test_chat.py#lines-116

Notice how we are checking only the number of messages saved per user. This has to be extended to check if the messages saved are the ones sent to them before.

[Vaibhav Mehra]

@Shivashis Padhi I will like to contribute to this issue. I have understood the script of chat.py but the statement “messages saved are the ones sent to them before” is not clear to me so can you please elaborate a bit more.

[Shivashis Padhi]

Hi Vaibhav, comment here when you’ve gone through overview, and documentation of mss. Set the project up, and I’ll walk you through the changes you have to make to solve this issue. For now, I’ll assign you this.

[Vaibhav Mehra]

@Shivashis Padhi Sir I have gone through both the documents mentioned in the readme.md file of this repository. Also I have searched and read many scripts of this repository. Is there anything else I should go through before starting to work.

[Shivashis Padhi]

vaibhav is not working on this at present in case someone wants to take this up.

[Vaibhav Mehra]

@Shivashis Padhi I am willing to work on this but I was asking about a clear explanation of what “messages saved are the ones sent to them before”. So can you please help

[Shivashis Padhi]

My bad, so after sending a message through automated test, we’re now testing if count of messages incremented by one, you can check the linked file in issue-description.
It’s a one line change, to also assert the message content to be same as the one sent.

[Vaibhav Mehra]

@Shivashis Padhi Is there any way to directly run test_chat.py?

‌

[Shivashis Padhi]

pytest -k “test_chat”

or pytest test_chat.py

[Vaibhav Mehra]

@Shivashis Padhi Sir there are many errors when I ran the above commands so is it normal or should I start working to fix them.

[Vaibhav Mehra]

@Shivashis Padhi I guess

assert messages[0]["text"] == "message from 1"

can resolve this issue or should I have to compare text in 0th and 1st position of list?

[Shivashis Padhi]

this works.

[Vaibhav Mehra]

@Shivashis Padhi Created PR for this. Kindly review it.

[Reimar Bauer]

Test if message's text field is saved properly.Closes #516

→ <<cset 24e52213cb25>>

[Reimar Bauer]

Merged in veb7vmehra/mss/test_chat (pull request #770)

Test if message's text field is saved properly.Closes #516

Approved-by: Shivashis Padhi [e-mail]

→ <<cset 5e02407a2abf>>