Phantom pilots (Pilot registration bug)

[Xwvm Art]

Currently, XWVM allows entering concourse with pilots that do not really exist.

Steps to reproduce:

1. Attempt to create a new pilot with a system file name (con, lpt1, etc.)
2. After you get the system file error message, hit cancel.
3. notice that the pilot was “created” anyway. at least in the registration, if not the hard drive.
4. Enter concourse

-Rasi

‌

[Xwvm Art]

Fix applied in commit #9d68a41 - should attempt to create pilot file first and only add internally if this succeeds.

-Dez

[Xwvm Art]

This seems to be fixed with the name mangling scheme. Creating a pilot called CON now created file called 20201205-CON.vmpilot. The name in the registration desk shows correctly as CON and there is no problem coming in/out of concourse.

‌

@Jason McNew