Opening crafting window sometimes doesn't trigger event TRADE_SKILL_UPDATE, resulting in known recipes not being discovered.

[Clinton Mead]

RecipeRadarClassic is working fine for my cooking and tailoring which are both around level 90, but my enchanting at level 20 it doesn’t know I’ve learnt "Enchant Chest - Minor Mana".

I put some debug statements in RecipeRadar_OnEvent, found that TRADE_SKILL_UPDATE was not being raised upon opening my enchanting window but was for cooking and tailoring.

I registered the TRADE_SKILL_SHOW event in RecipeRadar_OnLoad and caught it in RecipeRadar_OnEvent and called RecipeRadar_SkillDB_Refresh (exactly as is done on TRADE_SKILL_UPDATE) and all was good.

I suspect that perhaps “TRADE_SKILL_UPDATE” isn’t called unless the number of tradeskills overruns the window.

Note I am also running on linux with the “Wide Quest Log” addon, so I’m not sure if these two factors affect things.

I haven’t done any WoW modding before nor Lua so perhaps my fix has problems but this is just what came from me putting “RecipeRadar_Print” everywhere to work out what was going on.

[Kernighan Ritchie]

Thanks for the report! Crafting was handled differently in Classic than in later versions of WoW, and RR Classic is a backport from later WoW, so I’m guessing this is an event that needs to be tracked now. I’ll add TRADE_SKILL_UPDATE in for the next release.

[Kernighan Ritchie]

Err, TRADE_SKILL_SHOW even.

[Kernighan Ritchie]

Fix #17 - Register event TRADE_SKILL_SHOW

→ <<cset 9ee827bb36e2>>