- attached ms.diff
decimal support for MSSQL
Issue #1282
resolved
Attached is a patch that fixes insertion of small decimal numbers in MSSQL
Comments (12)
-
Account Deleted
-
repo owner
- changed milestone to 0.5.xx
dupe of
#1280? can we figure out which patch is most effective here... -
Account Deleted
Yep this is a dupe... Sorry I did not search much to see if there was some other related problem.
My code does not have unit tests... but I can add them if you give me some directions. Appart from that I would say choose the one you want.
The less code I have to maintain myself the happier I am :p
Florent Aide
-
- changed status to duplicate
-
Account Deleted
- changed status to open
- removed status
Sorry to bother you but the patch in 1280 is false.
a decimal instance ._int attribute is not a string or even an int... it is a tuple.
The test that was added is not run by the default test suite but if you setup an mssql server to test it you get an error saying that:
'tuple' object as no attribute 'zfill'
I'll redo my patch again to make it cleaner, but please consider this issue as still open.
-
Account Deleted
- attached decimal_support_mssql_dialect.diff
Decimal support for mssql dialect
-
Account Deleted
- attached test_decimal_notation_mssql.diff
Test for decimal support in mssql dialect
-
Account Deleted
Please disregard the ms.diff file, and use the 2 others patches attached to this ticket.
-
Account Deleted
With this patch, the mssql test case runs smoothly.
-
Okay the additional tests still do not cause the test to fail. Were you getting failures with the additional test criteria?
-
-
repo owner
- removed milestone
Removing milestone: 0.5.2 (automated comment)
- Log in to comment
Patch to fix support of Decimal type in MSSQL dialect