sqlite right-nested joins now function

Issue #3634 resolved
Mike Bayer repo owner created an issue

the test given in http://docs.sqlalchemy.org/en/rel_1_0/changelog/migration_09.html#many-join-and-left-outer-join-expressions-will-no-longer-be-wrapped-in-select-from-as-anon-1 for SQlite now passes. we need to turn off join rewriting for SQLite and basically mothball the whole feature.

sitll working to bisect which SQLite version this is repaired within.

also see #3633.

would want to turn this off by default in 1.1 but for 1.0 perhaps use a flag as this is a big change.

Comments (12)

  1. Mike Bayer reporter

    OK so far the failure is in 3.7.6.3 (from 2011) but not in 3.8.3 (from 2014). narrowing further

  2. Mike Bayer reporter
    • documenation updates to clarify specific SQLite versions that have problems with right-nested joins and UNION column keys; references #3633 references #3634. backport from 1.1 to 0.9 announcing 1.1 as where these behaviors will be retired based on version-specific checks
    • fix test_resultset so that it passes when SQLite 3.10.0 is present, references #3633

    → <<cset 89fa08792e98>>

  3. Mike Bayer reporter
    • documenation updates to clarify specific SQLite versions that have problems with right-nested joins and UNION column keys; references #3633 references #3634. backport from 1.1 to 0.9 announcing 1.1 as where these behaviors will be retired based on version-specific checks
    • fix test_resultset so that it passes when SQLite 3.10.0 is present, references #3633

    (cherry picked from commit 89fa08792e98b9e31452aa3c949d9b909b10e7cd)

    → <<cset 9cc769ac4004>>

  4. Mike Bayer reporter
    • documenation updates to clarify specific SQLite versions that have problems with right-nested joins and UNION column keys; references #3633 references #3634. backport from 1.1 to 0.9 announcing 1.1 as where these behaviors will be retired based on version-specific checks
    • fix test_resultset so that it passes when SQLite 3.10.0 is present, references #3633

    (cherry picked from commit 89fa08792e98b9e31452aa3c949d9b909b10e7cd)

    → <<cset dc4eb7904e22>>

  5. Mike Bayer reporter
    • The workaround for right-nested joins on SQLite, where they are rewritten as subqueries in order to work around SQLite's lack of support for this syntax, is lifted when SQLite version 3.7.16 or greater is detected. fixes #3634
    • The workaround for SQLite's unexpected delivery of column names as tablename.columnname for some kinds of queries is now disabled when SQLite version 3.10.0 or greater is detected. fixes #3633

    → <<cset 9d9fc93b7065>>

  6. Log in to comment