- edited description
Test codes are not PEP8 compliant
Wanted to contribute to sqlalchemy and thought I could help by improving the test codes to be pep8 compliant. Especially after reading the following in the develop
section:
Tests should stick to PEP8. Many older tests currently do not; this is an area in which we welcome new help.
Running the command below inside sqlalchemy (master, c703b9ce89) folder will produce 9413 lines with pep8 related issues. Tested using pycodestyle
version 2.2.0
pycodestyle tests/ | wc -l
Current work is being done at https://github.com/khairihafsham/sqlalchemy/tree/pep8-tests
Comments (4)
-
reporter -
repo owner thanks very much!!
-
repo owner - changed status to resolved
Make all tests to be PEP8 compliant
tested using pycodestyle version 2.2.0
Fixes:
#3885Change-Id: I5df43adc3aefe318f9eeab72a078247a548ec566 Pull-request: https://github.com/zzzeek/sqlalchemy/pull/343→ <<cset 772374735da2>>
-
repo owner thanks a TON for this! I can see a lot of it was done manually, thanks so much for that effort!
- Log in to comment