cascading delete-orphan relationships disrupted by joined table inheritance
This is difficult to explain, so let me just show you:
from sqlalchemy import String, Integer, Column, create_engine, ForeignKey
from sqlalchemy.orm import relationship, Session
from sqlalchemy.ext.declarative import declarative_base
Base = declarative_base()
class Company(Base):
__tablename__ = 'company'
id = Column(Integer, primary_key=True)
name = Column(String, nullable=False)
employees = relationship('Employee', cascade='all,delete-orphan')
class Employee(Base):
__tablename__ = 'employee'
id = Column(Integer, primary_key=True)
type = Column(String, nullable=False)
name = Column(String, nullable=False)
company_id = Column(Integer, ForeignKey('company.id'), nullable=False)
__mapper_args__ = {
'polymorphic_on': 'type',
'with_polymorphic': '*',
}
class Programmer(Employee):
__tablename__ = 'programmer'
id = Column(Integer, ForeignKey('employee.id'), primary_key=True)
languages = relationship('Language', cascade='all,delete-orphan')
__mapper_args__ = {
'polymorphic_identity': 'programmer',
}
class Language(Base):
__tablename__ = 'language'
id = Column(Integer, primary_key=True)
programmer_id = Column(
Integer,
ForeignKey('programmer.id'),
nullable=False,
)
name = Column(String, nullable=False)
engine = create_engine('postgresql://localhost:5432/sa')
Base.metadata.drop_all(engine)
Base.metadata.create_all(engine)
db = Session(engine)
company = Company(
id=1,
name='Foobar Corp',
employees=[Programmer(
id=1,
name='John Smith',
languages=[Language(id=1, name='Python')],
)],
)
db.add(company)
db.flush()
company.employees = []
db.flush()
What I expect to happen is the second flush would perform roughly the following SQL:
delete language where programmer_id=1
delete programmer where id = 1
delete employee where id = 1
Instead, I get the following error:
sqlalchemy.exc.IntegrityError: (psycopg2.IntegrityError) update or delete on table "programmer" violates foreign key constraint "language_programmer_id_fkey" on table "language"
DETAIL: Key (id)=(1) is still referenced from table "language".
[SQL: 'DELETE FROM programmer WHERE programmer.id = %(id)s'] [parameters: {'id': 1}]
I've played around with various configurations, and it seems to be a very specific case that fails:
- Removing
delete-orphan
fromProgrammer.languages
and makinglanguage.id
nullable works fine. - Performing
db.delete(programmer)
instead ofcompany.employees = []
works fine.
Comments (3)
-
repo owner -
repo owner - changed status to resolved
Cascade mappers in terms of the instance's mapper
Fixed a (extremely old) bug in cascade_mappers where the first cascade we do is against the "self" mapper, and not the one that actually corresponds to the state given. These are different in the case where we start with a relationship to a class, and the instance is of a subclass, which itself can have relationships that aren't on the base mapper.
A pretty severe bug that somehow has avoided the radar since the beginning.
Change-Id: I512956b9757b07e06f3ca1ccb507a33fb10bed31 Fixes:
#3986→ <<cset 0f8721fa52e3>>
-
repo owner Cascade mappers in terms of the instance's mapper
Fixed a (extremely old) bug in cascade_mappers where the first cascade we do is against the "self" mapper, and not the one that actually corresponds to the state given. These are different in the case where we start with a relationship to a class, and the instance is of a subclass, which itself can have relationships that aren't on the base mapper.
A pretty severe bug that somehow has avoided the radar since the beginning.
Change-Id: I512956b9757b07e06f3ca1ccb507a33fb10bed31 Fixes:
#3986(cherry picked from commit 0f8721fa52e335ab2abeb548c8914b99a8c5e1fd)→ <<cset 06af579db292>>
- Log in to comment
you landed a pretty big fish here, congrats!
patches running through CI at https://gerrit.sqlalchemy.org/#/q/I512956b9757b07e06f3ca1ccb507a33fb10bed31