wait until above horizon doesn't display the time

Issue #1215 resolved

Paolo Stivanin created an issue 2023-02-15

The utility “Wait until Above horizon” doesn’t display the target time, but only the current altitude.

While the instruction is working fine (the sequence stops when target is below the specified offset), the time is always displayed as ...

How to reproduce:

create a sequence
put “wait unitl above horizon” instruction
add a dso target (tried with different targets [IC 1848, IC 1805, LDN 1355], always the same result)
initially, with offset 0 it shows 00:00 as time. As soon as the offset is changed (e.g. 30), the time become ...

‌

OS: Windows 10

NINA: 2.1 HF1 RC005

Location: northern Italy

Screenshot_from_2023-02-15_13-21-27.png

Comments (17)

Paolo Stivanin reporter
- edited description
- 2023-02-15T12:26:56+00:00

Paolo Stivanin reporter

I’ve set the log level to debug, this is the output:

‌

----------------------------------------------------------------------
----------------NINA - Nighttime Imaging 'N' Astronomy----------------
-------------------Running NINA Version 2.1.1.3005--------------------
-------------------------2023-02-15T13:33:38--------------------------
---------------------.NET Version 4.0.30319.42000---------------------
---------------------Oparating System Information---------------------
---------------------------Is 64bit OS True---------------------------
------------------------Is 64bit Process True-------------------------
---------------------------Platform Win32NT---------------------------
--------------Version Microsoft Windows NT 10.0.19045.0---------------
---------------------------Major 10 Minor 0---------------------------
----------------------------Service Pack -----------------------------
----------------------------------------------------------------------
DATE|LEVEL|SOURCE|MEMBER|LINE|MESSAGE
2023-02-15T13:33:40.2005|INFO|CameraChooserVM.cs|GetEquipment|71|Found 0 ASI Cameras
2023-02-15T13:33:40.2786|INFO|CameraChooserVM.cs|GetEquipment|86|Found 0 Altair Cameras
2023-02-15T13:33:40.5599|INFO|CameraChooserVM.cs|GetEquipment|98|Found 0 Atik Cameras
2023-02-15T13:33:40.5599|DEBUG|FLICameras.cs|GetCameras|28|FLI: Found 0 camera(s)
2023-02-15T13:33:40.5599|INFO|CameraChooserVM.cs|GetEquipment|112|Found 0 FLI Cameras
2023-02-15T13:33:41.5911|INFO|CameraChooserVM.cs|GetEquipment|132|Found 0 QHYCCD Cameras
2023-02-15T13:33:41.7317|INFO|CameraChooserVM.cs|GetEquipment|160|Found 0 ToupTek Cameras
2023-02-15T13:33:41.7322|INFO|CameraChooserVM.cs|GetEquipment|172|Found 0 Ogma Cameras
2023-02-15T13:33:41.7478|INFO|CameraChooserVM.cs|GetEquipment|184|Found 0 Omegon Cameras
2023-02-15T13:33:41.8724|INFO|CameraChooserVM.cs|GetEquipment|196|Found 0 RisingCam Cameras
2023-02-15T13:33:41.8880|INFO|CameraChooserVM.cs|GetEquipment|208|Found 0 MallinCam Cameras
2023-02-15T13:33:41.8880|DEBUG|SBIGCameraProvider.cs|GetEquipment|45|Getting SBIG Cameras
2023-02-15T13:33:41.9192|INFO|CameraChooserVM.cs|GetEquipment|231|Found 0 SBIG Cameras
2023-02-15T13:33:41.9973|DEBUG|FLIFilterWheels.cs|GetFilterWheels|28|FLI: Found 0 filter wheel(s)
2023-02-15T13:33:41.9973|DEBUG|QHYFilterWheels.cs|GetFilterWheels|62|QHYCFW: Found 0 filter wheel(s)
2023-02-15T13:33:42.0130|DEBUG|SBIGFilterWheelProvider.cs|GetEquipment|40|Getting SBIG Filter Wheels
2023-02-15T13:33:42.1535|DEBUG|DllLoader.cs|LoadDll|568|Successfully loaded C:\Program Files\N.I.N.A. - Nighttime Imaging 'N' Astronomy\External\x64\FTDI\ftd2xx.dll
2023-02-15T13:33:42.1535|DEBUG|DllLoader.cs|LoadDll|568|Successfully loaded C:\Program Files\N.I.N.A. - Nighttime Imaging 'N' Astronomy\External\x64\MGEN\MG3lib.dll
2023-02-15T13:33:43.9818|INFO|ApplicationVM.cs|CheckASCOMPlatformVersion|78|ASCOM Platform 6.6.1.3673 installed
2023-02-15T13:33:44.0746|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Constants for Exposures version 1.1.0.0 by Marc Blank
2023-02-15T13:33:44.1332|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Darks Customs version 1.2.2.0 by S. Dimant & Stefan Berg
2023-02-15T13:33:44.3222|DEBUG|GroundStation.cs|Initialize|61|Init completed
2023-02-15T13:33:44.3222|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Ground Station version 1.14.0.0 by Dale Ghent
2023-02-15T13:33:44.8340|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Hocus Focus version 2.0.0.4 by George Hilios (jokogeo)
2023-02-15T13:33:44.8936|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Moon Angle version 1.6.0.0 by Dale Ghent
2023-02-15T13:33:44.9413|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Orbuculum version 1.0.5.0 by Stefan Berg
2023-02-15T13:33:45.0356|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Target Planning version 1.2.1.0 by Tom Palmer @tcpalmer
2023-02-15T13:33:45.1052|INFO|PluginLoader.cs|LoadPlugin|398|Successfully loaded plugin Three Point Polar Alignment version 1.7.2.0 by Stefan Berg
2023-02-15T13:33:45.1936|INFO|PluginFetcher.cs|RequestAll|42|Fetching plugin manifests from https://nighttime-imaging.eu/wp-json/nina/v1/plugins/manifest
2023-02-15T13:33:45.2591|DEBUG|SVBonyProvider.cs|GetEquipment|49|Getting SVBony Cameras
2023-02-15T13:33:45.2631|INFO|CameraChooserVM.cs|GetEquipment|251|Found 0 SVBony Cameras
2023-02-15T13:33:45.2641|DEBUG|PlayerOneProvider.cs|GetEquipment|47|Getting Player One cameras
2023-02-15T13:33:45.2681|INFO|CameraChooserVM.cs|GetEquipment|251|Found 0 PlayerOne Cameras
2023-02-15T13:33:45.2691|DEBUG|ASTPANProvider.cs|GetEquipment|37|Getting ASTPAN Cameras
2023-02-15T13:33:45.2730|INFO|CameraChooserVM.cs|GetEquipment|251|Found 0 ASTPAN Cameras
2023-02-15T13:33:45.3078|INFO|CameraChooserVM.cs|GetEquipment|264|Found 7 ASCOM Cameras
2023-02-15T13:33:45.3108|INFO|CameraChooserVM.cs|GetEquipment|277|Found 0 Canon Cameras
2023-02-15T13:33:46.5130|INFO|PluginFetcher.cs|RequestAll|55|Found 73 valid plugins at https://nighttime-imaging.eu/wp-json/nina/v1/plugins/manifest
2023-02-15T13:33:46.6692|DEBUG|AutoFocusToolVM.cs|LoadChart|295|Finished loading latest AutoFocus chart
2023-02-15T13:33:50.4664|INFO|FramingAssistantVM.cs|LoadImage|1108|Loading image from source FILE with field of view 3.89040659279773° for coordinates RA: 00:00:00; Dec: 00° 00' 00"; Epoch: J2000
2023-02-15T13:33:53.1499|DEBUG|XISF.cs|Load|68|XISF: Opening file "C:\Users\paolo\Documents\N.I.N.A\LDN 1355\2023-02-14\LIGHT\B_-5.00_0_11_80.00s_0000.xisf"
2023-02-15T13:33:53.1906|DEBUG|XISF.cs|Load|111|XISF: File geometry: width=6252, height=4176
2023-02-15T13:33:53.1916|DEBUG|XISF.cs|Load|150|XISF: CompressionType: LZ4HC, UncompressedSize: 52216704, IsShuffled: True, ItemSize: 2
2023-02-15T13:33:53.1926|DEBUG|XISF.cs|Load|183|XISF: Checksum type: SHA256, Hash: e70581ea9916be9635b4511185c6f7f00843304d02df2c05e9b5cea806ba11ab
2023-02-15T13:33:53.1926|DEBUG|XISF.cs|Load|198|XISF: Data block type: attachment, Data block start: 8192, Data block size: 26369108
2023-02-15T13:33:55.5920|INFO|ImageSolver.cs|Solve|41|Platesolving with parameters: FocalLength: 350 PixelSize: 3.76 SearchRadius: 30 BlindFailoverEnabled: False Regions: 5000 DownSampleFactor: 0 MaxObjects: 500 Reference Coordinates RA: 02:52:30 Dec: 68° 59' 47" Epoch: J2000
2023-02-15T13:33:56.2960|INFO|BaseImageData.cs|FinalizeSave|162|Finalize image and moving it to C:\Users\paolo\AppData\Local\NINA\PlateSolver\ouuvirko.mze.fits
2023-02-15T13:33:56.3049|DEBUG|CLISolver.cs|StartCLI|165|Starting process 'C:\Program Files\astap\astap.exe' with args '-f "C:\Users\paolo\AppData\Local\NINA\PlateSolver\ouuvirko.mze.fits" -fov 2.570413 -z 0 -s 500 -r 30 -ra 2.875081 -spd 158.99647'
2023-02-15T13:33:59.1169|INFO|ImageSolver.cs|Solve|54|Platesolve successful: Coordinates: RA: 02:52:28; Dec: 68° 58' 56"; Epoch: J2000
2023-02-15T13:34:04.6697|INFO|FramingAssistantVM.cs|InitializeCommands|254|Adding target to advanced sequencer: LDN 1355 - RA: 02:52:28; Dec: 68° 58' 56"; Epoch: J2000
2023-02-15T13:34:04.6853|DEBUG|ItemUtility.cs|Iterate|256|MoonAltitudeCondition: CalculateExpectedTime failed after 19 iterations, Custom: False
2023-02-15T13:34:09.7010|DEBUG|ItemUtility.cs|Iterate|256|MoonAltitudeCondition: CalculateExpectedTime failed after 19 iterations, Custom: False
2023-02-15T13:34:14.7167|DEBUG|ItemUtility.cs|Iterate|256|MoonAltitudeCondition: CalculateExpectedTime failed after 19 iterations, Custom: False
2023-02-15T13:34:19.7310|DEBUG|ItemUtility.cs|Iterate|256|MoonAltitudeCondition: CalculateExpectedTime failed after 19 iterations, Custom: False
2023-02-15T13:34:24.7437|DEBUG|ItemUtility.cs|Iterate|256|MoonAltitudeCondition: CalculateExpectedTime failed after 19 iterations, Custom: False
2023-02-15T13:34:29.7479|DEBUG|ItemUtility.cs|Iterate|256|MoonAltitudeCondition: CalculateExpectedTime failed after 19 iterations, Custom: False

‌

2023-02-15T12:36:22+00:00

Marc Blank
I will look into this; I’m wondering if something changed in NINA recently to cause this…
- 2023-02-15T19:48:13+00:00
Marc Blank
Paolo: Are you using a custom horizon or not?
- 2023-02-15T19:54:07+00:00
Paolo Stivanin reporter
nope!
- 2023-02-15T19:58:38+00:00
Marc Blank
I see the issue and I’m looking into a fix for the next release… Thanks for the report.
- 2023-02-15T20:00:15+00:00
Paolo Stivanin reporter
thank you for the fix :)
- 2023-02-15T20:01:37+00:00
Stefan B repo owner
- changed status to resolved
Fix Issue ~~#1215~~ - wait until above horizon doesn't display the time when no custom horizon is used

→ <<cset f63b3f32d47d>>
- 2023-02-15T21:18:40+00:00
Stefan B repo owner
Fix Issue ~~#1215~~ - wait until above horizon doesn't display the time when no custom horizon is used

→ <<cset 1236b8f313af>>
- 2023-02-15T21:19:05+00:00
Paolo Stivanin reporter
I’ve update to the latest RC6. I’m not sure this is really fixed

wait until above horizon (works fine):

loop while above horizon (says “now” when the object is below the offset):

shows ~-- when the object is above the offset

summary:
- wait until above horizon: looks good
- loop while above horizon: seems still broken
‌
- 2023-02-16T09:03:26+00:00
Marc Blank
You never said there was a problem with the loop instruction until just now!
- 2023-02-16T09:32:45+00:00
Paolo Stivanin reporter
Ops, right. Sorry, my bad !! I thought I uploaded also that one yesterday.
- 2023-02-16T09:35:31+00:00
Marc Blank
The second screenshot is correct; the time shown is the time the loop will terminate. And it will terminate “Now” since the altitude is NOT above 40. I can’t comment on the last one without knowing what the target is; perhaps you can show the altitude chart from the sequencer. Note that if the target will never be below 30 degrees, then there is no time when the loop will end.
- 2023-02-16T23:07:12+00:00
Paolo Stivanin reporter
I tried with:
- M101 (it’s 22 degrees up at 08:23 CET). I’ve set the offset to 20, so I was expecting to see something around 12:55 CET in the time. Instead I see the ~--
- M16 (it’s 30 degrees up at 08:29 CET). I’ve set offset to 20, so I was expecting to see something around 11:50 CET in the time. Instead I see the same as above.
‌
- 2023-02-17T07:31:49+00:00
Paolo Stivanin reporter
Last nights it happened with LDN1355. It goes below 30 degrees at around 02:10 CET, but the time was never shown.
- 2023-02-17T07:32:24+00:00
Marc Blank
I’ll take a look again, but probably not in the next couple of weeks.
- 2023-02-17T07:44:07+00:00
Paolo Stivanin reporter
ok, thanks a lot Marc! And sorry for the previous mistake!
- 2023-02-17T09:15:49+00:00
Log in to comment

Assignee: –

Type: bug

Priority: minor

Status: resolved

Component: User Interface

Version: 2.1

Votes: 0

Watchers: 1