Enclose String value by ' ' in XSIF header

[Cyril Richard]

Hello,

I'm improving the xisf headers reader in Siril.
I looked at a header of a file produced by NINA 3.

Here is an example:

<FITSKeyword name="BAYERPAT" value="RGGB" comment="Sensor Bayer pattern" />

In my opinion, this should be :

<FITSKeyword name="BAYERPAT" value="'RGGB'" comment="Sensor Bayer pattern" />

surrounding the string value with '.
(even

“'RGGB    '“

for small strings)

Even PixInsight does this for string keywords.

[Stefan B]

Hey Cyril,

thank you for your report. I've looked at the XISF specification again and while it is not explicitly mentioned there, it just refers to the FITS specification for Header Keywords.

So I agree that this seems to be incorrectly written by N.I.N.A. and I will add a patch for it

[Cyril Richard]

Thx a lot.

Cheers,

[Stefan B]

Fix Issue #1284 - Enclose String value by ' ' in XSIF header for FITSHeader string values

→ <<cset 0254f712733c>>

[Stefan B]

Will be available with the next Beta (019)

[Cyril Richard]

Thank you Stefan