Incorrect voice actor images
Incorrect voice actor images are returned for characters with more than one voice actor. You can see an example by visiting /anime/cast/20
. Notice that voice actor images are the same for all languages (it sends the last image in the list from MAL for all entries).
The fix is quick:
CastParser.php, line 76: $item->...
should be $crawler->...
I figured since the change is so small it would be easier for all of us to just make an issue rather than a PR. :)
Thanks!
Comments (8)
-
-
-
assigned issue to
-
assigned issue to
-
- changed status to resolved
-
Hi this is my first request; I started using the API this week.
I'd like to create a new issue but probably this can be handled in this issue because it's so similar.
So my issue: when importing the cast of an anime, the images of the voice actors are wrong a lot of the time; usually I get for each language the image of the german voice actor.
An example: cast for Steins;Gate with MAL id 9253 returns following json. Notice that for each voice actor for each language the same image is given: https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/41146.jpg .
It would be great if this can be solved.
Thanks in advance.
{ "Characters":[ { "id":35258, "name":"Hashida, Itaru", "role":"Main", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/6\/113767.jpg", "actors":[ { "id":1, "name":"Seki, Tomokazu", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/25773.jpg", "language":"Japanese" }, { "id":19069, "name":"Rinehart, Tyson", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/25773.jpg", "language":"English" }, { "id":20558, "name":"Vivio, Paolo", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/25773.jpg", "language":"Italian" }, { "id":22365, "name":"Wirthgen, Jesco", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/25773.jpg", "language":"German" } ] }, { "id":34470, "name":"Makise, Kurisu", "role":"Main", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/10\/114399.jpg", "actors":[ { "id":1804, "name":"Nishimura, Trina", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40336.jpg", "language":"English" }, { "id":8662, "name":"Imai, Asami", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40336.jpg", "language":"Japanese" }, { "id":14773, "name":"Wu, Jeong Sin", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40336.jpg", "language":"Korean" }, { "id":24931, "name":"Paolelli, Rachele", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40336.jpg", "language":"Italian" }, { "id":40044, "name":"B\u00e4cker, Manuela", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40336.jpg", "language":"German" } ] }, { "id":35252, "name":"Okabe, Rintarou", "role":"Main", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/6\/122643.jpg", "actors":[ { "id":65, "name":"Miyano, Mamoru", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/41146.jpg", "language":"Japanese" }, { "id":1602, "name":"Tatum, John Michael", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/41146.jpg", "language":"English" }, { "id":1678, "name":"Chevalier, Davide", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/41146.jpg", "language":"Italian" }, { "id":15099, "name":"Hong, Si Ho", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/41146.jpg", "language":"Korean" }, { "id":40188, "name":"Gavrilis, Marios", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/41146.jpg", "language":"German" } ] }, { "id":35253, "name":"Shiina, Mayuri", "role":"Main", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/4\/131329.jpg", "actors":[ { "id":185, "name":"Hanazawa, Kana", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/39140.jpg", "language":"Japanese" }, { "id":1415, "name":"Padoan, Eva", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/39140.jpg", "language":"Italian" }, { "id":14769, "name":"Yeo, Min Jeong", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/39140.jpg", "language":"Korean" }, { "id":30377, "name":"Burch, Ashly", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/39140.jpg", "language":"English" }, { "id":36982, "name":"Morgenstern, Friedel", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/39140.jpg", "language":"German" } ] }, { "id":44274, "name":"Akiha, Yukitaka", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/13\/121808.jpg", "actors":[ { "id":312, "name":"Vale, Eric", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/10790.jpg", "language":"English" }, { "id":11677, "name":"Kikumoto, Taira", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/10790.jpg", "language":"Japanese" } ] }, { "id":35256, "name":"Akiha, Rumiho", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/2\/142621.jpg", "actors":[ { "id":258, "name":"Momoi, Haruko", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/39604.jpg", "language":"Japanese" }, { "id":6729, "name":"Saxton, Jad", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/39604.jpg", "language":"English" }, { "id":14929, "name":"Kim, Seo Yeong", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/39604.jpg", "language":"Korean" }, { "id":20246, "name":"Ionica, Emanuela", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/39604.jpg", "language":"Italian" }, { "id":23755, "name":"F\u00f6lster, Julia", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/39604.jpg", "language":"German" } ] }, { "id":35255, "name":"Amane, Suzuha", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/3\/148223.jpg", "actors":[ { "id":27, "name":"Tamura, Yukari", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/34215.jpg", "language":"Japanese" }, { "id":1650, "name":"Leigh, Cherami", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/34215.jpg", "language":"English" }, { "id":8464, "name":"Favazza, Valentina", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/34215.jpg", "language":"Italian" }, { "id":14983, "name":"Chae, Ui Jin", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/34215.jpg", "language":"Korean" }, { "id":33351, "name":"Uhlig, Charlotte", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/34215.jpg", "language":"German" } ] }, { "id":35257, "name":"Kiryuu, Moeka", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/12\/275310.jpg", "actors":[ { "id":211, "name":"Gotou, Saori", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40290.jpg", "language":"Japanese" }, { "id":1184, "name":"Lenghi, Laura", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40290.jpg", "language":"Italian" }, { "id":7705, "name":"Baumgardt, Birte", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40290.jpg", "language":"German" }, { "id":10912, "name":"Cavanagh, Jessica", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/40290.jpg", "language":"English" } ] }, { "id":89637, "name":"Maid", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "actors":[ { "id":24657, "name":"Aiba, Yukiko", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/27271.jpg", "language":"Japanese" } ] }, { "id":41897, "name":"Nakabachi", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/5\/114001.jpg", "actors":[ { "id":872, "name":"Williams, Kent", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/15243.jpg", "language":"English" }, { "id":8483, "name":"Ogata, Mitsuru", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/15243.jpg", "language":"Japanese" } ] }, { "id":38559, "name":"Tennouji, Nae", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/9\/176875.jpg", "actors":[ { "id":659, "name":"Palencia, Brina", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "language":"English" }, { "id":12477, "name":"Yamamoto, Ayano", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "language":"Japanese" }, { "id":42733, "name":"Tanfal, Chiara", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "language":"German" } ] }, { "id":38558, "name":"Tennouji, Yuugo", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/12\/125685.jpg", "actors":[ { "id":253, "name":"Sabat, Christopher", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46051.jpg", "language":"English" }, { "id":563, "name":"Terasoma, Masaki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46051.jpg", "language":"Japanese" }, { "id":1234, "name":"Draghetti, Roberto", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46051.jpg", "language":"Italian" }, { "id":42663, "name":"Boden, Leon", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46051.jpg", "language":"German" } ] }, { "id":41913, "name":"Titor, John", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "actors":[ { "id":340, "name":"Seitz, Patrick", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46549.jpg", "language":"English" }, { "id":6214, "name":"Tsuchida, Hiroshi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46549.jpg", "language":"Japanese" }, { "id":42645, "name":"Pucci, Fabrizio", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46549.jpg", "language":"Italian" }, { "id":43054, "name":"Weigert, Jacob", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/46549.jpg", "language":"German" } ] }, { "id":42945, "name":"Urushibara, Eisuke", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/10\/117125.jpg", "actors":[ { "id":666, "name":"McCollum, Robert", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/31539.jpg", "language":"English" }, { "id":945, "name":"Hoshino, Mitsuaki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/31539.jpg", "language":"Japanese" } ] }, { "id":30919, "name":"Urushibara, Ruka", "role":"Supporting", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/characters\/7\/133805.jpg", "actors":[ { "id":34, "name":"Kobayashi, Yuu", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/45967.jpg", "language":"Japanese" }, { "id":10881, "name":"Seidel, Lindsay", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/45967.jpg", "language":"English" }, { "id":14777, "name":"Eom, Sang Hyeon", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/45967.jpg", "language":"Korean" }, { "id":33325, "name":"Pollow, Peggy", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/45967.jpg", "language":"German" }, { "id":41950, "name":"Tarquini, Giulia", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/45967.jpg", "language":"Italian" } ] } ], "Staff":[ { "id":16015, "name":"Iwasa, Gaku", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/18233.jpg", "rank":"Producer" }, { "id":32079, "name":"Yasuda, Takeshi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/38760.jpg", "rank":"Producer, Planning" }, { "id":6369, "name":"Hamasaki, Hiroshi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/44508.jpg", "rank":"Director, Episode Director, Storyboard, Key Animation" }, { "id":9572, "name":"Satou, Takuya", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/32695.jpg", "rank":"Director, Episode Director, Storyboard" }, { "id":14703, "name":"Kobayashi, Tomoki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/43404.jpg", "rank":"Episode Director, Storyboard" }, { "id":42430, "name":"Kobayashi, Kouji", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Episode Director" }, { "id":18371, "name":"Tachikawa, Yuzuru", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/2\/25109.jpg", "rank":"Episode Director" }, { "id":12198, "name":"Hanada, Jukki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/11662.jpg", "rank":"Script, Series Composition" }, { "id":8136, "name":"Nemoto, Toshizou", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/43217.jpg", "rank":"Script" }, { "id":1602, "name":"Tatum, John Michael", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/3151.jpg", "rank":"Script" }, { "id":19175, "name":"Yokotani, Masahiro", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Script" }, { "id":11845, "name":"Kato, Toshiyuki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Storyboard" }, { "id":5297, "name":"Itou, Kanako", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/38541.jpg", "rank":"Theme Song Performance" }, { "id":492, "name":"Sakakibara, Yui", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/8897.jpg", "rank":"Theme Song Performance" }, { "id":19313, "name":"Shikura, Chiyomaru", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/46909.jpg", "rank":"Theme Song Lyrics, Theme Song Composition, Planning" }, { "id":14749, "name":"5pb.", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/18993.jpg", "rank":"Original Creator" }, { "id":12130, "name":"Abo, Takeshi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/44324.jpg", "rank":"Music" }, { "id":38676, "name":"Afilia Saga", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/41286.jpg", "rank":"Inserted Song Performance" }, { "id":40210, "name":"Aono, Atsushi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation, Animation Director" }, { "id":34253, "name":"Arai, Nobuhiro", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Animation Director, Key Animation" }, { "id":472, "name":"Clinkenbeard, Colleen", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/30191.jpg", "rank":"ADR Director" }, { "id":5316, "name":"Fukunaga, Gen", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/24531.jpg", "rank":"Executive Producer" }, { "id":28583, "name":"Hamaguchi, Akira", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"2nd Key Animation" }, { "id":41254, "name":"Hirata, Kazuya", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":39602, "name":"Igari, Takashi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation, Animation Director" }, { "id":19167, "name":"Ikariya, Atsushi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/25809.jpg", "rank":"Key Animation" }, { "id":33997, "name":"Kawasaki, Aika", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":38875, "name":"Komatsubara, Sei", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":40500, "name":"Kouji, Etou", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/44472.jpg", "rank":"Background Art, Art Director" }, { "id":34387, "name":"Maeda, Yuki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Background Art" }, { "id":42043, "name":"Mitsuda, Hajime", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":9447, "name":"Miyamoto, Takeshi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":15229, "name":"Nakamura, Kazuhisa", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation, Assistant Animation Director, Animation Director" }, { "id":4960, "name":"Nitroplus", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/3\/45878.jpg", "rank":"Original Creator" }, { "id":39024, "name":"Okuda, Yousuke", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":7126, "name":"Oota, Kazuhiro", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":11111, "name":"Sakai, Kyuta", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation, Chief Animation Director, Character Design, Animation Director" }, { "id":38842, "name":"Satou, Miyuki", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Color Design" }, { "id":11561, "name":"Shibata, Shirou", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":34281, "name":"Sugiura, Miho", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Background Art" }, { "id":21017, "name":"Tomioka, Hiroshi", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/questionmark_23.gif", "rank":"Key Animation" }, { "id":10145, "name":"huke", "image":"https:\/\/myanimelist.cdn-dena.com\/images\/voiceactors\/1\/46395.jpg", "rank":"Original Character Design" } ] }
-
I see now that this issue is exactly the same and I used the solution on my own application; it works like a charm!
Maybe I should switch to the development branch for this app?
-
reporter @DimitriBe I recommend using the develop branch. I typically use the develop branch on the server I run. Minor fixes like this usually go into the develop branch, along with new features. The branch is also pretty stable. I subscribe to updates on the repo so I can see what changes are coming out so I can make changes to my client if needed!
-
The develop branch is not recommended but just like Kyle said it does get more fixes BUT the develop branch can break due changes so please keep that in mind. We have test files to ensure that it doesn't break but we can't cover everything.
-
- Log in to comment
I will look at this later today