- edited description
Manga type wrong
Issue #135
resolved
When trying to grab the type of a manhwa (a korean manga) i.e https://myanimelist.net/manga/30079/Annarasumanara, the API 'says' it's a manga, when it is a manhwa.
EDIT: manhua works on the other hand.
Comments (6)
-
reporter
-
It is probably a parsing issue. We can take care of this soon.
-
Hey, you found a legacy bug!
I did some digging and the old API we used to use spelled it "manwha". Looks like we carried that over when we built this API. I'm very surprised nobody caught this earlier, or it was valid and MAL corrected their romanization at some point in the past which broke the code.
I'm working on a patch for both our release and development code to handle the "legacy" spelling and properly parse the correct spelling.
-
- changed status to resolved
Update Model to Handle Manhwa
Set the model to handle manhwa. It looks like MAL adjusted the spelling from the older “manwha” version. Still handle the older spelling for queries.
NOTE: THIS POTENTIALLY BREAKS TOOLS EXPECTING THE OLDER SPELLING RETURNED IN THE MANGA TYPE.
Fixes
#135→ <<cset afd40b5c4669>>
-
Update Model to Handle Manhwa
Set the model to handle manhwa. It looks like MAL adjusted the spelling from the older “manwha” version. Still handle the older spelling for queries.
NOTE: THIS POTENTIALLY BREAKS TOOLS EXPECTING THE OLDER SPELLING RETURNED IN THE MANGA TYPE.
Fixes
#135→ <<cset 8cb8d9027b01>>
-
One last note: It looks like MAL used to spell it as "manwha". You can still use that spelling in many locations as the "type" and it changes to "manhwa". No idea when that was changed.
Example: https://myanimelist.net/topmanga.php?type=manwha redirects to https://myanimelist.net/topmanga.php?type=manhwa
- Log in to comment
