Plugin causing a 500 error on Repository Pull Request Settings screen

[Mike Schroeder]

When the plugin is enabled in Stash, everything appears to be working until you navigate to a respository and try to update the pull request settings. You get a 500 error screen as seen in the attachment.

I tried disabling all of the individual modules independently in an attempt to narrow it down with no luck.

Running Stash 2.9.2

[Georgy Bolyuba]

I see the place in the code where this issue originates and trying to reproduce it now. The message "This should never happen, ever" is a catch code which throws an exception in the place guarded by predicate that (according stash api contract) will never be true. Even if I will not be able to reproduce an issue I will try to work out the "closest to correct" behaviour in this case.

[Georgy Bolyuba]

fixes #16, minor improvements, removing deprecated API calls scheduled for for removal in 3.0

→ <<cset b7c8d1c93605>>