Approvers who utilize the block/ublock functionality are removed from the list of approvers.
For any users that have clicked block/unblock, it appears to all other reviewers and the creator that they are no longer a reviewer of the pull request. This is a very big problem for our team because my approve/decline status is no longer associated with the approvers status in the upper right of the pull request's page - see attachment. Unfortunately I'll have to stop using the plugin until this can be resolved as it prevents my developers from seeing all approver's status for their pull request.
My inbox also doesn't show the pull request once i've unblocked (or been automatically via the "Remove blocks from all participants when the source branch of a pull request changes" repo setting) the pull request. This may also be caused by the apparent "unlinking" of the user from the pull request mentioned above.
Comments (8)
-
-
- changed status to resolved
fixes
#18, proper inbox functionality is for 2.0.0→ <<cset cf388f3ac5f1>>
-
A side-effect of
#5and the way Stash API works with participants/reviewers -
reporter Wow, quick fix @bolyuba! What might the timeline look like for getting this into the atlassian marketplace?
-
-
assigned issue to
- changed component to Block button
- changed version to 1.2.2
-
assigned issue to
-
Regression suit passed, 1.2.2 in on marketplace
-
There are a couple of issues with inbox item (such as block icon will not be removed until page is reloaded) that I know about and will fix in 2.0.0.
-
reporter That's awesome, thanks for the quick turnaround!
- Log in to comment
Trying to reproduce