Approve Icons being hidden after page load
Initial page shows approve icon overhead, but as soon as this plugin runs it is removing the approve icon. Stranger yet it seems to be only doing it for some users on some pull requests.
I did some debugging and it appears to be in this code:
if(C){
if(A){
C.find(".badge").addClass("blocked").removeClass("approved")
}
else{
C.find(".badge").removeClass("blocked").addClass("approved")
}
C.toggleClass("badge-hidden",!A)
}
obviously that is the compressed code, but should point you to where you need to look
Here is the state of the gui before the C.toggleclass is hit:
<span class="aui-avatar aui-avatar-small aui-avatar-badged user-avatar avatar-dimmed avatar-tooltip participant-item" data-username="timschroeder"><span class="aui-avatar-inner"><img src="https://secure.gravatar.com/avatar/d012966f34c38acc4cb3881c5d5bea38.jpg?s=48&d=mm" alt="Tim Schroeder" title="Tim Schroeder"></span><span class="badge approved">✓</span></span>
and after:
<span class="aui-avatar aui-avatar-small aui-avatar-badged user-avatar avatar-dimmed avatar-tooltip participant-item badge-hidden" data-username="timschroeder"><span class="aui-avatar-inner"><img src="https://secure.gravatar.com/avatar/d012966f34c38acc4cb3881c5d5bea38.jpg?s=48&d=mm" alt="Tim Schroeder" title="Tim Schroeder"></span><span class="badge approved">✓</span></span>
Comments (11)
-
-
I patched this locally as it was really quite annoying. The !A or !blocked should just be A in min and blocked in regular. Please fix this its trivial.
-
So we pay for this plugin and you don't even respond to issue requests that include the fix? What the heck?
-
Apologies, I missed this report. Gonna take a look today
-
Thanks. Any update? It should really be just removing the ! before the variable.
-
Will push out new version to market place this weekend
-
- changed status to resolved
1.3.1 patch release, fixes
#29→ <<cset 97a72e1e4953>>
-
Pushed out new release to market place. I am wondering how exactly did you patch it locally. Did you simply removed C.toggleClass("badge-hidden",!A) ?
-
- changed version to 1.3.1
-
- changed component to Block button
-
assigned issue to
-
- changed component to UI
- Log in to comment
This was with Stash 3.2.0 btw.