Padding Issue on Navbar
Issue #122
resolved
Commit 2613cfd removed padding from the main navbar:
- padding: 0px 20px 0px; +/ padding: 0px 20px 0px;/
- padding: 0;
which has the effect of removing padding entirely so home, my home navbar links all sit on top of one another.
I am not sure if there is another setting to get this padding back?
Issues #104 and #105 mention padding being inconssitent with other elements and causing issues on mobile but I am unclear why altering ".navbar .nav > li > a" would impact that due to its specificity?
There is an issue with padding on those elements in that the only impact on horizontal padding seems to be padded or not, i.e. 0 makes it collapse, anything other than 0 puts padding back but does not alter the gap?
I am going to put this padding back for the interim as its going to break our live site if we deploy this update.
Comments (9)
-
reporter
-
It is duplicated in menu.css and custom.css.
Comment the menu.css and test it. I made changes in custom.css to align the menu items to the left margin and also to get the padding in horizontal.
-
custom.css
There are different media breaks. I don't think we need so much. Maybe 768 and 1024 would be enough.
-
reporter
I saw the change to custom.css you made but that was only applied in a media query 768 and should not have affected desktop (which is where I am seeing the issue with padding). I think the number of media queries should be looked at but perhaps do that later.
-
I don't see any problem but let me test it in the test server.
-
I found the problem.
.navbar .nav > li and .navbar .nav > li > a
My proposal is add the padding to the right instead the left (the menu is aligned to left)
We will solve the problem also in mobile view.
The only question is that the tools menus are not moved to the bottom in mobile view and are beside the home.
By other han, the font size is too small. Actually is 12px and should be at least 14px or even 16px
-
reporter
I had a look at this earlier and made some changes as a temporary fix. There are a few issues here:
1) The tools menu adds a separate ul which addes more padding 2) Using padding applies to the full screen / hide blocks which we dont really want as these can be styled differently
The whole thing is a but of a mess now, I think we really need to get "tools" into the same ul as the rest of the items in that part of the menu after which it should be a lot easier to work with.
-
- changed status to resolved
fix
#122→ <<cset a6b1929ddd92>>
-
fix
#122→ <<cset a6b1929ddd92>>
- Log in to comment
I just put this back with 39859e2