Issues to Complete for Release

Issue #223 resolved
Jeremy Hopkins created an issue

We need to decide which issues are requried to fix for release. Below I list what I think needs to be done, you may wish to add more. If we add all we need to do here and once resolved re-run code checker for the first version

There are a number of changes we should make to admin settings before release as this would cause significant chage at upgrade (of the theme): #216 , #217 , #218 , #219 , #220 #222

Beyond these I am not aware of any we need, but would like to complete the following which I found could cause issues on new installs (found when changing default install settings): #213 , #211

Comments (13)

  1. Info 3bits

    I would add the CodeChecker review as a task. Even I made many changes to allow to pass the filter, there are still a lot of errors and warnings that will not pass the the really crazy warnings.

    If the lang file is stable then i will add the spanish translation.

  2. Jeremy Hopkins reporter

    Code checker should be added as an issue we can commit against but I would add that at the time its needed in case we need to add other "actual" issues. I dont think the lang is stable yet.

    If you look at the way "alerts" works now there is a field to set the number you want to use and that loops out in the admin settings, thus I think we will be removing some strings.

    Another issue will remove lang strings for social icons and replace with fields (making it more intuitive to use, based on an issue Alex raised a while back).

    The descriptions in menus need some work to make them more concise too.

  3. Info 3bits

    Just a silly idea about the social buttons that would optimize the code and be more flexible.

    The idea is to add the number of social networks, or links, and then create a loop to enter the content. With the network name and link is enough. Then we can render the icon (from FA) with the link.

    This will avoid fixed fields and open the site to add other networks or links like Paypal, Dropbox or Vimeo just to say some non-standard networks.

    For example:

    Settings: Number of social icons: x

    Loop for 1 to x Social network x: xxxxxxxxx (render the fa-xxxxxxxxx icon) Link social network x: http://xxxxxxx.xxx

  4. Jeremy Hopkins reporter

    I am not sure what you mean, but keep in mind we are completely customising this so they are not social at all, but link to email, student records system etc.

    However, based on what you said I think it could be done with a single de-limited text field much like Moodle custom menus along the lines of:

    • title|url|icon
    • facebook|http://facebook.com|fa fa-facebook
    • twitter|http://twitter.com|fa fa-twitter
  5. Info 3bits

    As a moodle user said in the moodle forum, add more info to the settings.

    For example, the logo size in pixels, a link to font-awesome icons list and a screen layout. I made the last one some weeks ago but no time to add it to the settings page:

    adaptable layout.png

  6. Jeremy Hopkins reporter

    This screen shot looks a really good idea, where you going to just embed the image in a settings page, or try to replicate all that in code?

  7. Info 3bits

    The idea is to add the image in the settings page and open in a pop up window. Go to try and see the result

  8. Log in to comment