Issue with display order of Jigit tab panel in issue's activity log

[Alexander Schüßler]

Dear Dmitrii,

we are featuring an issue with the new displaying of commits in issue activity log as of the (generally very good) improvement as of issue #76

It is is that the order of the inline commit tabs is not correct. Please find a screenshot attached where you can see this. The tabs added by Jigit to show commits are always displayed “too early” though the timestamp does show the correct time.

I assume it is something related to time zones.
First I thought it might be as we did not set a timezone explicitly on our Gitlab server but now I changed the Gitlab server’s timezone to Europe/Berlin what is correct, but it still shows the wrong order.

Actual State:
The tab panel for commits shows the correct time but is displayed at the wrong position (earlier in the history).

Expected State:
The tab panel for commits shows up accordingly to the time being displayed and not disordered.

[Dmitrii Apanasevich]

Hi Alex,

I really grateful for your detailed report because such feedback helps to improve the add-on. Let’s discuss your points.

Do you think it could also be a bug in your plugin?

I think it’s a bug of the plugin. Could you check whether the date of the pointed commit on the screenshot is correct according to GitLab data? Is “18 Jul 2018 10:46” a correct date?

In my honest opinion - the way how the subversion plugin outputs the data is actually perfect. Do you think you could do it like this?

I’d prefer not to switch back on that design.

They really would like to have it highlighted somehow.

Would it be enough to convert it into a link to a Gitlab branch? Do you have any idea of other ways of highlighting?

Our Jira is German and now we have no option to translate this (not very unpleasant but a cut in design though).

It’s easy to support German in the add-on. Jigit uses i18n, and all is needed is to translate content from jigit-plugin.properties to German. Here is a simple instruction. We could do it together in a separate branch: my initial commit and your translation. Are you interested in this kind of collaboration?

[Alexander Schüßler]

Hi Dmitrii,

I think it’s a bug of the plugin. Could you check whether the date of the pointed commit on the screenshot is correct according to GitLab data? Is “18 Jul 2018 10:46” a correct date?

I checked in Subversion here it is the correct time. Your plugin also shows the correct time, however in Gitlab itself It shows two hours earlier for some reason. I think this is the root cause. I need to investigate why this happens. It also happens for most recent commits we did not migrate from subversion.
I will check on my side and let you know.

Would it be enough to convert it into a link to a Gitlab branch? Do you have any idea of other ways of highlighting

I would just suggest to change the text in tab from
[Author} {URLtoCommit|commited} {DateTime} to {Branch} of {repository}

{DateTime} - {Author} added a commit to {URLtoCommit|Branch} of {repository}

It’s easy to support German in the add-on. Jigit uses i18n, and all is needed is to translate content from jigit-plugin.properties to German. Here is a simple instruction. We could do it together in a separate branch: my initial commit and your translation. Are you interested in this kind of collaboration?

For sure - I am not that experienced with Git as of developer’s perspective but I will check with my Gitlab admin developer (I am just technical support admin) how to create a proper pull request against your Bitbucket.
Kindly let me know if you will implement my suggestion above, as it might affect the properties file with the english source.

[Alexander Schüßler]

Hi,

I was able to determine that the Gitlab server timezone is “UTC” - but should be “Europe/Berlin”. I will ask my leader if I am allowed to make the change in the gitlab config file.
Maybe this will resolve the display order issue.

Regarding localization and reformatting tab output of course I am still available for collaboration.

[Alexander Schüßler]

Hi Dmitrii,

I now updated our Gitlab server to the correct timezone, but sadly this does not change display order in Jira activity panel (even though I did a complete reindex of one of my smaller repositories) so I fear there is still something wrong in Jigit plugin. However I can confirm that changing the Gitlab server timezone fixed the displayed timestamps in Gitlab itself.

Can you approve what I am saying in your plugin’s code?

[Dmitrii Apanasevich]

Hi Alex,

Can you approve what I am saying in your plugin’s code?

I have a suspicious piece of code. But I'm confused with the fact that it’s only you who faced the problem.

I have to check my idea, and would be grateful if you installed a special build of the add-on to confirm that a fix works. I'll provide you with a build later.

[Alexander Schüßler]

Hi @Dmitrii Apanasevich ,

for sure. I have a Jira test instance available on my side for checking.
Yes I am also confused. I noticed that most on our Gitlab server looks normal now regarding timestamps, however I found that the log files are still in UTC - but maybe it’s by design..not sure.

‌

Feel free to send the test build.

[Dmitrii Apanasevich]

Here is a special build. Keep me informed, please.

[Alexander Schüßler]

Hi @Dmitrii Apanasevich ,

‌

good news, it looks like your change fixed the issue for me.
See attached screenshot with regular version 1.2.12 on the left and modified 1.2.12 on the right side. As you can see now the commit panels of Jigit have been moved to the right position (compare with the Subversion plugin that is still active in my test system for reference).

If you don’t think that your change will affect other installations in a bad way, kindly feel free to merge your change into master

Thanks a lot for this.

[Alexander Schüßler]

Hi @Dmitrii Apanasevich ,

‌

I just wonder if you will merge your change into master and release a new version with changes from Issue 81 and Issue 83.
I have yet installed your beta build to our production Jira and can confirm it looks good, but I’d love to install an official build again and close my Jira issue I have on my side for this.

Thanks and have a good day.

[Dmitrii Apanasevich]

Hi Alexander,

Sorry, I was on vacation and away from the keyboard.

Yes, I’ll fix this issue and Issue#83 in the nearest release.

[Dmitrii Apanasevich]

Fixes #81: Issue with display order of Jigit tab panel in issue's activity log

→ <<cset 4eee0d31f610>>

[Alexander Schüßler]

Hi @Dmitrii Apanasevich

no worries, I yet supposed so but didn’t expect it would be that long. Lucky guy. Thanks for closing the issue.

I will merge it with the fork on our side and update the language file for Issue #83 as requested and will return a new pull request. Let me try whether I can find out how to directly place it into your repository.
FYI my Gitlab admin developer is just playing with Jigit source and some of the things we try to optimize it for our workflows might be interesting for the community as well.

Currently we try to add a feature in Tab panel so it is possible to separate between author and comitter, since we work a lot with merge requests in Gitlab. If I find it useful in general I will open a new issue and send our pull request for this idea.

[Dmitrii Apanasevich]

FYI my Gitlab admin developer is just playing with Jigit source and some of the things we try to optimize it for our workflows might be interesting for the community as well.

Currently we try to add a feature in Tab panel so it is possible to separate between author and comitter, since we work a lot with merge requests in Gitlab. If I find it useful in general I will open a new issue and send our pull request for this idea.

Every idea is welcome!