Add German translation to Jigit plugin

[Alexander Schüßler]

Hi,

as mentioned in #81 I like to offer my collaboration on translating the plugin into German.
For documentation purposes I create a new issue therefore.

Since I don’t know yet if you will implement my suggestion in #82 I will wait for your feedback regarding #82, before I start preparing translation.

[Alexander Schüßler]

Hi @Dmitrii Apanasevich ,

I attached the fork of your plugin with German translation. Note that I am not a Java developer so please have a look on the changes I made:

• Updated version of Plugin in pom.xml
• Added localized file for de_DE
• added one localization for “Change token” - please especially check this
• Therefore also modifed origin property file.

If you find everything okay, please merge it into your next version.

[Dmitrii Apanasevich]

Hi Alexander,

I’ve added two more keys while fixing #81. They are:

jigit-tab-panel.commits.commited=commited
jigit-tab-panel.commits.destination=to {0} of {1}

Please, translate them to German too.

[Alexander Schüßler]

HI @Dmitrii,

here is the latest German translation file. I found that I can't place pull requests and now I spent more than a hour trying to create a diff file that shows the difference between your master and my German translation branch in my fork repository...but I failed...I am familar with SVN, but with Git now even the simplest things become impossible..*sob

[Dmitrii Apanasevich]

Fixes #83: Add German translation to Jigit plugin

→ <<cset d8665782d847>>

[Dmitrii Apanasevich]

Hi,

I’ve prepared a release here. Could you check whether German interface is ok?

[Alexander Schüßler]

Hi Dmitrii,

thanks a lot for applying the commit.

There are a few small things I like to change so please find them below (the comments are just FYI - you can remove them)

Old: jigit-tab-panel.commits.commited=erstellte einen Commit
New: jigit-tab-panel.commits.commited=erstellte einen Commit am /* Respects the fact that a timestamp follows */

Or even better: Let me suggest to move the timestamp to beginning or end of the line. It will always be difficult to have this translated properly because Jira uses different expressions like the raw timestamp but also stuff like “a few minutes ago”, “just now”, “4 hours ago”, “6 days ago”.
Please consider to change it, for instance like so:
{$user} commited to {$branch} of {$repository} - {$timestamp}

Please note that also Jira natively does it mostly like this. See a screenshot below for your reference:

If you decide to do so for jigit-tab-panel.commits.commited the old value needs to be kept.

Old: jigit.confirm.delete.repo=Sine Sie sicher, dass Sie diesen Branch löschen möchten?
New: jigit.confirm.delete.repo=Sine Sie sicher, dass Sie dieses Repository löschen möchten? /* Copy/paste error….*/

Old: jigit.buttons.clear=Neuindizieren
New: jigit.buttons.clear=Neu indizieren /* Sounds better indeed */

Any chance we can highlight the repository name and branch name a little as mentioned in #82? It is very difficult to quickly extract this information:

[Dmitrii Apanasevich]

Or even better: Let me suggest to move the timestamp to beginning or end of the line. It will always be difficult to have this translated properly because Jira uses different expressions like the raw timestamp but also stuff like “a few minutes ago”, “just now”, “4 hours ago”, “6 days ago”.

Please consider to change it, for instance like so:

{$user} commited to {$branch} of {$repository} - {$timestamp}

Please note that also Jira natively does it mostly like this. See a screenshot below for your reference

Thanks for the suggestion. You are right. It looks like it’s better to place datetime info at the end or at the beginning of the sentence.

Any chance we can highlight the repository name and branch name a little as mentioned in #82? It is very difficult to quickly extract this information:

Of course, but a bit later, after this issue.

[Dmitrii Apanasevich]

Hi Alexander,

I’ve re-uploaded a new version. Please, try it.

[Alexander Schüßler]

Hi @Dmitrii Apanasevich ,

looks very good now! I made some finetuning though for my German file again.

Please find my diff file attached.

Changes I made:

• Localization for “Index all branches” => missing for Russian now
• Typo in jigit.confirm.delete.repo => sorry
• Rolled back change in jigit-tab-panel.commits.commited => no longer necessary as you moved the timestamp!
  Warning!!! This change is not included in the diff-file - please change it manually back and remove the “am”
• Changed some phrasing so it sounds better in German

Thanks for collaboration and have a nice weekend.

[Dmitrii Apanasevich]

Thank you for for your willingness to participate and for thoroughness in translation. You’ve managed to catch two hardcoded sentences on admin page. I hope you’ll help to translate new phrases if they occur in future.

I appreciate you help and feedback.

[Alexander Schüßler]

Sure. Is there any chance I can get notifications if changes are applied? Don’t know if I can subscribe to a repository or so…..

[Dmitrii Apanasevich]

Hi,

All your issues are resolved and the new version is available on Marketplace.

[Alexander Schüßler]

HI @Dmitrii Apanasevich ,

‌

sorry for getting back late. I yet installed the latest version on monday morning and can confirm that I am really happy with current solution. Thanks for all your efforts.