1. Einstein Toolkit Avatar Einstein Toolkit
  2. Einstein Toolkit
  3. tickets
  4. Issues

Get Presync into the Toolkit

Issue #2338 resolved
Steven R. Brandt created an issue

Merge the various Presync branches into master, review, and make it part of the release.

Comments (8)

  3. Roland Haas

    Pull requests:

    ‌

  4. Roland Haas

    I approve of adding presync’s branches (as listed in https://raw.githubusercontent.com/SamuelCupp/PreSync/master/presync.th) into their respective master branches. I have downloaded the thorns in that thornlist using the branches listed in there as well as any missing thorns (of which there were none) using the ET manifest’s einsteintoolkit.th in the master version. I compiled that code and ran the testsuites using at most 2 MPI ranks using generic.cfg on a Debian 10 system. No failures were found.

  5. Roland Haas

    Applied as git hash 0bbd6b45 "Merged in presync (pull request #88)" of cactus
    Applied as git hash 2649647 "Fix application of boundary reg." of cactusbase
    Applied as git hash d3b0362 "Merged in presync (pull request #2)" of cactusexamples
    Applied as git hash 1df3d2d0 "Merged in presync (pull request #11)" of cactusnumerical
    Applied as git hash 0aad81d "Merged in presync (pull request #2)" of cactustest
    Applied as git hash 9d9bea6 "Merged in presync (pull request #27)" of cactusutils
    Applied as git hash 7819e29 "Merged in presync (pull request #2)" of cactuswave
    Applied as git hash 40b7cd70 "Add some fortran dependencies" of carpet
    Applied as git hash e50f7ac5 "Merged in presync (pull request #11)" of einsteinanalysis
    Applied as git hash 6042cc3 "Merged in presync (pull request #1)" of einsteinbase
    Applied as git hash ae55e7b "Merged in presync (pull request #5)" of einsteineos
    Applied as git hash f49a487 "Merge pull request #6 from barrywardell/presync" of EinsteinExact
    Applied as git hash f3f0ebd0 "Merged in presync (pull request #9)" of einsteininitialdata
    Applied as git hash 51ed38e3 "Merged in presync (pull request #6)" of mclachlan

  7. Roland Haas

    Comments have been added to:
    CactusBase: https://bitbucket.org/cactuscode/cactusbase/pull-requests/8/presync/diff
    CactusExample: https://bitbucket.org/cactuscode/cactusexamples/pull-requests/2/presync/diff
    Cactus: https://bitbucket.org/cactuscode/cactus/pull-requests/88/presync/diff
    CactusNumerical: https://bitbucket.org/cactuscode/cactusnumerical/pull-requests/11/presync/diff
    CactusUtils: https://bitbucket.org/cactuscode/cactusutils/pull-requests/27/presync/diff
    CactusWave: https://bitbucket.org/cactuscode/cactuswave/pull-requests/2/presync/diff
    Carpet: https://bitbucket.org/eschnett/carpet/pull-requests/13/presync/diff
    EinsteinAnalysis: https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/11/presync/diff
    EinsteinBase: https://bitbucket.org/einsteintoolkit/einsteinbase/pull-requests/1/presync/diff
    EinsteinEOS: https://bitbucket.org/einsteintoolkit/einsteineos/pull-requests/5/presync/diff
    EinsteinInistialData: https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/9/presync/diff

    No comments for McLachlan or EinsteinExact. Both are Kranc generated and modify the generated code. See ticket #2348 for details. Both changes will have to be reverted (they will be overwritten when the code is regenerated from Kranc sources before the release).

  9. Log in to comment
Assignee
Type
enhancement
Priority
major
Status
resolved
Component
Cactus
Milestone
ET_2020_05
Version
–
Votes
0
Watchers
1
Jira: the preferred issue tracker for Bitbucket. Join the team!