Fixing WRITE statements for MoL scalars

[Samuel Cupp]

MoL implicitly sets the region when declaring the WRITES for its scalars. However, the default WRITE region for PreSync is currently ‘interior’, while scalars can only be written ‘everywhere'. This means that PreSync attempts to call SyncGroups and ApplyBCs on the scalar variables. It doesn’t actually do anything, as there’s no registered BCs and syncing a scalar does nothing. Still, there are quite a few empty function calls due to this. The WRITE statements in MoL should explicitly state ‘everywhere’, at least until PreSync is capable of automatically setting the WRITES of scalars to ‘everywhere’.

I’ve made these changes, and the associated pull request is here.

[Steven R. Brandt]

Here is a pull request that fixes this issue for your enjoyment: https://bitbucket.org/cactuscode/cactus/pull-requests/145/implement-scalars-default-to-everywhere

[Samuel Cupp]

I have tested this branch, and it does stop the incorrect behavior. I support merging this fix in once the various comments on the PR are resolved.

[Roland Haas]

PreSync now defaults to write everywhere for scalars as of git hash b39b9f87 "Cactus: Implement scalars default to everywhere" of cactus